Fix/752 fixed compiler warnings UI (#777)

jozefbakus · web-flow · commit b5cc95f757d0 · 2023-02-01T11:34:25.000+01:00
diff --git a/ui/.eslintrc.js b/ui/.eslintrc.js
@@ -24,5 +24,14 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2018, // Allows for the parsing of modern ECMAScript features
     sourceType: "module" // Allows for the use of imports
+  },
+  rules: {
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        "argsIgnorePattern": "_",
+      }
+    ]
   }
 };
diff --git a/ui/angular.json b/ui/angular.json
@@ -37,6 +37,9 @@
               "node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js",
               "node_modules/@clr/icons/clr-icons.min.js"
             ],
+            "allowedCommonJsDependencies": [
+              "fast-deep-equal"
+            ],
             "vendorChunk": true,
             "extractLicenses": false,
             "buildOptimizer": false,
@@ -133,5 +136,8 @@
         }
       }
     }
+  },
+  "cli": {
+    "analytics": false
   }
 }
diff --git a/ui/package-lock.json b/ui/package-lock.json
diff --git a/ui/package.json b/ui/package.json
@@ -41,20 +41,20 @@
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "^14.2.10",
-    "@angular-eslint/builder": "1.2.0",
-    "@angular-eslint/eslint-plugin": "1.2.0",
-    "@angular-eslint/eslint-plugin-template": "1.2.0",
-    "@angular-eslint/schematics": "1.2.0",
-    "@angular-eslint/template-parser": "1.2.0",
+    "@angular-eslint/builder": "^14.2.0",
+    "@angular-eslint/eslint-plugin": "^14.2.0",
+    "@angular-eslint/eslint-plugin-template": "^14.2.0",
+    "@angular-eslint/schematics": "^14.2.0",
+    "@angular-eslint/template-parser": "^14.2.0",
     "@angular/cli": "^14.2.10",
     "@angular/compiler-cli": "^14.2.12",
     "@angular/language-service": "^14.2.12",
     "@types/jasmine": "~3.6.0",
     "@types/jasminewd2": "~2.0.3",
     "@types/node": "^12.11.1",
-    "@typescript-eslint/eslint-plugin": "5.12.0",
-    "@typescript-eslint/parser": "5.12.0",
-    "eslint": "^8.9.0",
+    "@typescript-eslint/eslint-plugin": "5.49.0",
+    "@typescript-eslint/parser": "5.49.0",
+    "eslint": "^8.32.0",
     "eslint-config-prettier": "^6.10.1",
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-jsdoc": "37.9.3",
diff --git a/ui/src/app/components/admin/job-templates/job-templates-form/job-templates-form.component.spec.ts b/ui/src/app/components/admin/job-templates/job-templates-form/job-templates-form.component.spec.ts
@@ -112,7 +112,6 @@ describe('JobTemplatesFormComponent', () => {
   it(
     'createJobTemplate() should not dispatch create job template when dialog is not confirmed',
     waitForAsync(() => {
-      const id = 1;
       underTest.jobTemplateForm = { form: { valid: true } };
       const subject = new Subject<boolean>();
       const storeSpy = spyOn(store, 'dispatch');
@@ -156,7 +155,6 @@ describe('JobTemplatesFormComponent', () => {
   it(
     'updateJobTemplate() should not dispatch update job template when dialog is not confirmed',
     waitForAsync(() => {
-      const id = 1;
       underTest.jobTemplateForm = { form: { valid: true } };
       const subject = new Subject<boolean>();
       const storeSpy = spyOn(store, 'dispatch');
diff --git a/ui/src/app/components/admin/job-templates/job-templates-form/job-templates-form.component.ts b/ui/src/app/components/admin/job-templates/job-templates-form/job-templates-form.component.ts
@@ -168,7 +168,7 @@ export class JobTemplatesFormComponent implements OnDestroy {
     if (value == this.jobTypes.SHELL) {
       return this.jobTypesMap;
     }
-    return new Map([...this.jobTypesMap.entries()].filter(([k, v]) => v !== this.jobTypes.SHELL));
+    return new Map([...this.jobTypesMap.entries()].filter(([_, v]) => v !== this.jobTypes.SHELL));
   }
 
   ngOnDestroy(): void {
diff --git a/ui/src/app/components/admin/notification-rules/notification-rule/notification-rule.component.spec.ts b/ui/src/app/components/admin/notification-rules/notification-rule/notification-rule.component.spec.ts
@@ -16,7 +16,7 @@
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
 
 import { provideMockStore } from '@ngrx/store/testing';
-import { ActivatedRoute, Router } from '@angular/router';
+import { ActivatedRoute } from '@angular/router';
 import { of } from 'rxjs';
 import { RouterTestingModule } from '@angular/router/testing';
 import { Store } from '@ngrx/store';
@@ -30,9 +30,7 @@ import { NotificationRuleChanged } from '../../../../stores/notification-rules/n
 describe('NotificationRuleComponent', () => {
   let underTest: NotificationRuleComponent;
   let fixture: ComponentFixture<NotificationRuleComponent>;
-  let router: Router;
   let store: Store<AppState>;
-  let previousRouteService: PreviousRouteService;
 
   const dummyNotificationRule = NotificationRuleModelFactory.create(
     true,
@@ -83,8 +81,6 @@ describe('NotificationRuleComponent', () => {
         imports: [RouterTestingModule.withRoutes([])],
         declarations: [NotificationRuleComponent],
       }).compileComponents();
-      previousRouteService = TestBed.inject(PreviousRouteService);
-      router = TestBed.inject(Router);
       store = TestBed.inject(Store);
     }),
   );
diff --git a/ui/src/app/components/admin/notification-rules/notification-rules-form/notification-rules-form.component.spec.ts b/ui/src/app/components/admin/notification-rules/notification-rules-form/notification-rules-form.component.spec.ts
@@ -130,7 +130,6 @@ describe('NotificationRulesForm', () => {
   it(
     'CreateNotificationRule() should not dispatch create notification rule when dialog is not confirmed',
     waitForAsync(() => {
-      const id = 1;
       underTest.notificationRulesForm = { form: { valid: true } };
       const subject = new Subject<boolean>();
       const storeSpy = spyOn(store, 'dispatch');
@@ -174,7 +173,6 @@ describe('NotificationRulesForm', () => {
   it(
     'UpdateNotificationRule() should not dispatch update notification rule when dialog is not confirmed',
     waitForAsync(() => {
-      const id = 1;
       underTest.notificationRulesForm = { form: { valid: true } };
       const subject = new Subject<boolean>();
       const storeSpy = spyOn(store, 'dispatch');
diff --git a/ui/src/app/components/auth/login-dialog/login-dialog.component.spec.ts b/ui/src/app/components/auth/login-dialog/login-dialog.component.spec.ts
@@ -14,16 +14,14 @@
  */
 
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { provideMockStore, MockStore } from '@ngrx/store/testing';
+import { provideMockStore } from '@ngrx/store/testing';
 import { ClarityModule } from '@clr/angular';
 import { FormsModule } from '@angular/forms';
 import { LoginDialogComponent } from './login-dialog.component';
-import * as fromApp from '../../../stores/app.reducers';
 
 describe('WelcomeComponent', () => {
   let component: LoginDialogComponent;
   let fixture: ComponentFixture<LoginDialogComponent>;
-  let mockStore: MockStore<fromApp.AppState>;
   const initialAuthState = {
     username: 'test',
     isAuthenticated: false,
@@ -43,8 +41,6 @@ describe('WelcomeComponent', () => {
         declarations: [LoginDialogComponent],
         imports: [ClarityModule, FormsModule],
       }).compileComponents();
-
-      mockStore = TestBed.inject(MockStore);
     }),
   );
 
diff --git a/ui/src/app/components/auth/login-dialog/login-dialog.component.ts b/ui/src/app/components/auth/login-dialog/login-dialog.component.ts
@@ -15,10 +15,8 @@
 
 import { Component, OnDestroy, OnInit } from '@angular/core';
 import { Store } from '@ngrx/store';
-import { AppState, selectAuthState } from '../../../stores/app.reducers';
+import { selectAuthState } from '../../../stores/app.reducers';
 import { Subscription } from 'rxjs';
-import { Router } from '@angular/router';
-import { absoluteRoutes } from '../../../constants/routes.constants';
 import * as fromApp from '../../../stores/app.reducers';
 
 @Component({
diff --git a/ui/src/app/components/auth/login/login.component.spec.ts b/ui/src/app/components/auth/login/login.component.spec.ts
@@ -14,17 +14,15 @@
  */
 
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { provideMockStore, MockStore } from '@ngrx/store/testing';
+import { provideMockStore } from '@ngrx/store/testing';
 import { ClarityModule } from '@clr/angular';
 import { FormsModule } from '@angular/forms';
 import { LoginComponent } from './login.component';
-import * as fromApp from '../../../stores/app.reducers';
 import { AppInfoModelFactory } from '../../../models/appInfo.model';
 
 describe('LoginComponent', () => {
   let component: LoginComponent;
   let fixture: ComponentFixture<LoginComponent>;
-  let mockStore: MockStore<fromApp.AppState>;
   const initialAuthState = {
     username: 'test',
     isAuthenticated: false,
@@ -50,8 +48,6 @@ describe('LoginComponent', () => {
         declarations: [LoginComponent],
         imports: [ClarityModule, FormsModule],
       }).compileComponents();
-
-      mockStore = TestBed.inject(MockStore);
     }),
   );
 
diff --git a/ui/src/app/components/auth/welcome/welcome.component.spec.ts b/ui/src/app/components/auth/welcome/welcome.component.spec.ts
@@ -14,17 +14,15 @@
  */
 
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { provideMockStore, MockStore } from '@ngrx/store/testing';
+import { provideMockStore } from '@ngrx/store/testing';
 import { ClarityModule } from '@clr/angular';
 import { FormsModule } from '@angular/forms';
 import { WelcomeComponent } from './welcome.component';
-import * as fromApp from '../../../stores/app.reducers';
 import { RouterTestingModule } from '@angular/router/testing';
 
 describe('WelcomeComponent', () => {
   let component: WelcomeComponent;
   let fixture: ComponentFixture<WelcomeComponent>;
-  let mockStore: MockStore<fromApp.AppState>;
   const initialAuthState = {
     username: 'test',
     isAuthenticated: false,
@@ -44,8 +42,6 @@ describe('WelcomeComponent', () => {
         declarations: [WelcomeComponent],
         imports: [RouterTestingModule, ClarityModule, FormsModule],
       }).compileComponents();
-
-      mockStore = TestBed.inject(MockStore);
     }),
   );
 
diff --git a/ui/src/app/components/common/datagrid/filters/boolean-filter/boolean-filter.component.ts b/ui/src/app/components/common/datagrid/filters/boolean-filter/boolean-filter.component.ts
@@ -37,7 +37,7 @@ export class BooleanFilterComponent implements ClrDatagridFilterInterface<any>,
   }
 
   ngAfterViewInit(): void {
-    this.removeFiltersSubject.subscribe((_) => this.onRemoveFilter());
+    this.removeFiltersSubject.subscribe(() => this.onRemoveFilter());
   }
 
   ngOnDestroy(): void {
diff --git a/ui/src/app/components/common/datagrid/filters/datetime-range-filter/datetime-range-filter.component.ts b/ui/src/app/components/common/datagrid/filters/datetime-range-filter/datetime-range-filter.component.ts
@@ -40,11 +40,11 @@ export class DatetimeRangeFilterComponent implements ClrDatagridFilterInterface<
   }
 
   ngAfterViewInit(): void {
-    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe((newValue) => {
+    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe(() => {
       this.changes.next();
     });
 
-    this.removeFiltersSubject.subscribe((_) => this.onRemoveFilter());
+    this.removeFiltersSubject.subscribe(() => this.onRemoveFilter());
   }
 
   accepts(item: any): boolean {
diff --git a/ui/src/app/components/common/datagrid/filters/multiple-status-filter/multiple-status-filter.component.ts b/ui/src/app/components/common/datagrid/filters/multiple-status-filter/multiple-status-filter.component.ts
@@ -42,11 +42,11 @@ export class MultipleStatusFilterComponent implements ClrDatagridFilterInterface
   }
 
   ngAfterViewInit(): void {
-    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe((newValue) => {
+    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe(() => {
       this.changes.next();
     });
 
-    this.removeFiltersSubject.subscribe((_) => this.onRemoveFilter());
+    this.removeFiltersSubject.subscribe(() => this.onRemoveFilter());
   }
 
   ngOnDestroy(): void {
diff --git a/ui/src/app/components/common/datagrid/filters/number-range-filter/number-range-filter.component.ts b/ui/src/app/components/common/datagrid/filters/number-range-filter/number-range-filter.component.ts
@@ -13,7 +13,7 @@
  * limitations under the License.
  */
 
-import { AfterViewInit, Component, Input, OnInit } from '@angular/core';
+import { AfterViewInit, Component, Input } from '@angular/core';
 import { ClrDatagridFilterInterface } from '@clr/angular';
 import { Subject, Subscription } from 'rxjs';
 import { debounceTime, distinctUntilChanged } from 'rxjs/operators';
@@ -40,11 +40,11 @@ export class NumberRangeFilterComponent implements ClrDatagridFilterInterface<an
   }
 
   ngAfterViewInit(): void {
-    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe((newValue) => {
+    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe(() => {
       this.changes.next();
     });
 
-    this.removeFiltersSubject.subscribe((_) => this.onRemoveFilter());
+    this.removeFiltersSubject.subscribe(() => this.onRemoveFilter());
   }
 
   accepts(item: any): boolean {
diff --git a/ui/src/app/components/common/datagrid/filters/string-filter/string-filter.component.ts b/ui/src/app/components/common/datagrid/filters/string-filter/string-filter.component.ts
@@ -40,10 +40,10 @@ export class StringFilterComponent implements ClrDatagridFilterInterface<any>, A
   }
 
   ngAfterViewInit(): void {
-    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe((newValue) => {
+    this.modelSubscription = this.modelChanges.pipe(debounceTime(500), distinctUntilChanged()).subscribe(() => {
       this.changes.next();
     });
-    this.removeFiltersSubject.subscribe((_) => this.onRemoveFilter());
+    this.removeFiltersSubject.subscribe(() => this.onRemoveFilter());
   }
 
   ngOnDestroy(): void {
diff --git a/ui/src/app/components/runs/runs.component.spec.ts b/ui/src/app/components/runs/runs.component.spec.ts
@@ -16,15 +16,13 @@
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
 
 import { RunsComponent } from './runs.component';
-import { MockStore, provideMockStore } from '@ngrx/store/testing';
-import * as fromApp from '../../stores/app.reducers';
+import { provideMockStore } from '@ngrx/store/testing';
 import { ActivatedRoute } from '@angular/router';
 import { of } from 'rxjs';
 
 describe('RunsComponent', () => {
   let component: RunsComponent;
   let fixture: ComponentFixture<RunsComponent>;
-  let mockStore: MockStore<fromApp.AppState>;
 
   const initialAppState = {
     auth: {},
diff --git a/ui/src/app/components/workflows/workflow-form/dynamic-parts/combobox-part/combobox-part.component.ts b/ui/src/app/components/workflows/workflow-form/dynamic-parts/combobox-part/combobox-part.component.ts
@@ -49,7 +49,7 @@ export class ComboboxPartComponent implements OnInit {
     this.valueChange.emit(value);
   }
 
-  trackByFn(index, item) {
+  trackByFn(index, _) {
     return index;
   }
 }
diff --git a/ui/src/app/components/workflows/workflow-form/dynamic-parts/cron-quartz-part/validator/cron-quartz-expression.validator.ts b/ui/src/app/components/workflows/workflow-form/dynamic-parts/cron-quartz-part/validator/cron-quartz-expression.validator.ts
@@ -29,7 +29,7 @@ export class CronQuartzExpressionValidator implements Validator {
     // do nothing
   }
 
-  validate(c: UntypedFormControl) {
+  validate(_: UntypedFormControl) {
     if (this.params) {
       return null;
     } else {
diff --git a/ui/src/app/components/workflows/workflow-form/dynamic-parts/key-value-list-part/key-value-list-part.component.ts b/ui/src/app/components/workflows/workflow-form/dynamic-parts/key-value-list-part/key-value-list-part.component.ts
@@ -44,7 +44,7 @@ export class KeyValueListPartComponent implements OnInit {
     }
   }
 
-  trackByFn(index, item) {
+  trackByFn(index, _) {
     return index;
   }
 
diff --git a/ui/src/app/components/workflows/workflow-form/dynamic-parts/key-value-map-part/key-value-map-part.component.ts b/ui/src/app/components/workflows/workflow-form/dynamic-parts/key-value-map-part/key-value-map-part.component.ts
@@ -47,7 +47,7 @@ export class KeyValueMapPartComponent implements OnInit {
     }
   }
 
-  trackByFn(index, item) {
+  trackByFn(index, _) {
     return index;
   }
 
diff --git a/ui/src/app/components/workflows/workflow-form/dynamic-parts/string-sequence-part/string-sequence-part.component.ts b/ui/src/app/components/workflows/workflow-form/dynamic-parts/string-sequence-part/string-sequence-part.component.ts
@@ -55,11 +55,11 @@ export class StringSequencePartComponent implements OnInit, OnChanges, AfterCont
     }
   }
 
-  ngOnChanges(changes: SimpleChanges): void {
+  ngOnChanges(_: SimpleChanges): void {
     this.setDefaultValue();
   }
 
-  trackByFn(index, item) {
+  trackByFn(index, _) {
     return index;
   }
 
diff --git a/ui/src/app/components/workflows/workflow-form/jobs/job/job-types/hyperdrive-job/hyperdrive-job.component.spec.ts b/ui/src/app/components/workflows/workflow-form/jobs/job/job-types/hyperdrive-job/hyperdrive-job.component.spec.ts
@@ -21,7 +21,7 @@ import { hyperdriveTypesFields } from '../../../../../../../constants/hyperdrive
 import { HyperdriveTemplateParametersModel } from '../../../../../../../models/jobTemplateParameters.model';
 import { JobTemplateChangeEventModel } from '../../../../../../../models/jobTemplateChangeEvent';
 import { EventEmitter } from '@angular/core';
-import { KeyValueModel, KeyValueModelFactory } from '../../../../../../../models/keyValue.model';
+import { KeyValueModelFactory } from '../../../../../../../models/keyValue.model';
 
 describe('HyperdriveJobComponent', () => {
   let fixture: ComponentFixture<HyperdriveJobComponent>;
diff --git a/ui/src/app/components/workflows/workflow-form/jobs/job/job.component.ts b/ui/src/app/components/workflows/workflow-form/jobs/job/job.component.ts
@@ -95,7 +95,7 @@ export class JobComponent {
     if (value == this.jobTypes.SHELL) {
       return this.jobTypesMap;
     }
-    return new Map([...this.jobTypesMap.entries()].filter(([k, v]) => v !== this.jobTypes.SHELL));
+    return new Map([...this.jobTypesMap.entries()].filter(([_, v]) => v !== this.jobTypes.SHELL));
   }
 
   getSelectedJobTemplateParameters(): JobTemplateParameters {
diff --git a/ui/src/app/components/workflows/workflow-form/workflow-form.component.spec.ts b/ui/src/app/components/workflows/workflow-form/workflow-form.component.spec.ts
diff --git a/ui/src/app/stores/app.reducers.ts b/ui/src/app/stores/app.reducers.ts
diff --git a/ui/src/app/stores/application/application.effects.ts b/ui/src/app/stores/application/application.effects.ts
diff --git a/ui/src/app/stores/auth/auth.effects.ts b/ui/src/app/stores/auth/auth.effects.ts
diff --git a/ui/src/app/stores/job-templates/job-templates.effects.spec.ts b/ui/src/app/stores/job-templates/job-templates.effects.spec.ts
diff --git a/ui/src/app/stores/job-templates/job-templates.effects.ts b/ui/src/app/stores/job-templates/job-templates.effects.ts
diff --git a/ui/src/app/stores/notification-rules/notification-rules.effects.spec.ts b/ui/src/app/stores/notification-rules/notification-rules.effects.spec.ts
diff --git a/ui/src/app/stores/notification-rules/notification-rules.effects.ts b/ui/src/app/stores/notification-rules/notification-rules.effects.ts
diff --git a/ui/src/app/stores/runs/runs.effects.ts b/ui/src/app/stores/runs/runs.effects.ts
diff --git a/ui/src/app/stores/workflows/workflows.effects.ts b/ui/src/app/stores/workflows/workflows.effects.ts

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@`
`37`	`37`	`"node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js",`
`38`	`38`	`"node_modules/@clr/icons/clr-icons.min.js"`
`39`	`39`	`],`
	`40`	`+ "allowedCommonJsDependencies": [`
	`41`	`+ "fast-deep-equal"`
	`42`	`+ ],`
`40`	`43`	`"vendorChunk": true,`
`41`	`44`	`"extractLicenses": false,`
`42`	`45`	`"buildOptimizer": false,`
`@@ -133,5 +136,8 @@`
`133`	`136`	`}`
`134`	`137`	`}`
`135`	`138`	`}`
	`139`	`+ },`
	`140`	`+ "cli": {`
	`141`	`+ "analytics": false`
`136`	`142`	`}`
`137`	`143`	`}`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ export class JobTemplatesFormComponent implements OnDestroy {`
`168`	`168`	`if (value == this.jobTypes.SHELL) {`
`169`	`169`	`return this.jobTypesMap;`
`170`	`170`	`}`
`171`		`- return new Map([...this.jobTypesMap.entries()].filter(([k, v]) => v !== this.jobTypes.SHELL));`
	`171`	`+ return new Map([...this.jobTypesMap.entries()].filter(([_, v]) => v !== this.jobTypes.SHELL));`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`ngOnDestroy(): void {`