Skip to content

Conversation

@zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Oct 1, 2025

In the validate of TransactionPayment, need to check the transaction to prevent the transaction from being broadcast even if the balance is insufficient.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.97%. Comparing base (a97f6db) to head (7652def).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
modules/transaction-payment/src/lib.rs 57.69% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
- Coverage   62.02%   61.97%   -0.05%     
==========================================
  Files          69       69              
  Lines        9482     9496      +14     
==========================================
+ Hits         5881     5885       +4     
- Misses       3601     3611      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zjb0807 zjb0807 merged commit 1733d4f into master Oct 2, 2025
7 checks passed
@zjb0807 zjb0807 deleted the fix-validate branch October 2, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants