-
Notifications
You must be signed in to change notification settings - Fork 715
add pallet-xcm benchmarks #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
=======================================
Coverage 47.86% 47.86%
=======================================
Files 83 83
Lines 9566 9566
=======================================
Hits 4579 4579
Misses 4987 4987 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/bench runtime acala |
|
Request: Running... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found potential configuration issues with DOT_UNITS in Acala and Mandala runtimes, which may lead to incorrect delivery fee calculations. Also identified unwrap() usage in benchmark code that could be safer, and noted that the weights files mentioned in the PR description are missing from the diff.
|
/bench runtime karura |
|
Request: Results |
|
/bench runtime mandala |
|
Request: Running... |
|
The PR regenerates weights for Acala, Karura, and Mandala runtimes, including Review Suggestionsruntime/acala/src/weights/pallet_xcm.rs:142-143 The weight for runtime/acala/src/weights/pallet_xcm.rs:346-357 The weights for runtime/karura/src/weights/pallet_xcm.rs:142-143 Same issue as Acala: runtime/karura/src/weights/pallet_xcm.rs:346-357 Same issue as Acala: runtime/mandala/src/weights/pallet_xcm.rs:136-137 Same issue as Acala: runtime/mandala/src/weights/pallet_xcm.rs:332-343 Same issue as Acala: |
followup #2947
The weights file needs to be regenerated by running benchmarks in a real environment.
Please double-check the pallet_xcm weights(
/src/weights/pallet_xcm.rs)