Fix additional duplicate LineIds for attributes (#12597)

Author: christothes

tools/apiview/parsers/csharp-api-parser/CSharpAPIParser/Program.cs

@@ -229,14 +229,22 @@ public static async Task<string> ExtractNugetDependencies(List<DependencyInfo> d
                     NullLogger.Instance,
                     CancellationToken.None))
                     {
+                        packageStream.Seek(0, SeekOrigin.Begin);
                         using PackageArchiveReader reader = new PackageArchiveReader(packageStream);
                         NuspecReader nuspec = reader.NuspecReader;
                         var file = reader.GetFiles().FirstOrDefault(f => f.EndsWith(dep.Name + ".dll"));
                         if (file != null)
                         {
                             var fileInfo = new FileInfo(file);
                             var path = Path.Combine(tempFolder, dep.Name, fileInfo.Name);
-                            var tmp = reader.ExtractFile(file, path, NullLogger.Instance);
+                            var directory = Path.GetDirectoryName(path);
+                            if (!string.IsNullOrEmpty(directory))
+                            {
+                                Directory.CreateDirectory(directory);
+                            }
+                            using Stream entryStream = reader.GetStream(file);
+                            await using FileStream destinationStream = new FileStream(path, FileMode.Create, FileAccess.Write, FileShare.None);
+                            await entryStream.CopyToAsync(destinationStream).ConfigureAwait(false);
                         }
                     }
                 }

tools/apiview/parsers/csharp-api-parser/CSharpAPIParser/TreeToken/CodeFileBuilder.cs

@@ -137,7 +137,7 @@ public static void BuildInternalsVisibleToAttributes(List<ReviewLine> reviewLine
                         if (!String.IsNullOrEmpty(param))
                         {
                             var firstComma = param?.IndexOf(',');
-                            param = firstComma > 0 ? param?[..(int)firstComma] : param;
+                            param = firstComma > 0 ? param?[..(int)firstComma] + "_" + param?[^5..] : param;
                             reviewLines.Add(new ReviewLine()
                             {
                                 LineId = attribute.AttributeClass?.Name + "_" + param,
@@ -475,13 +475,13 @@ private void BuildAttributes(List<ReviewLine> reviewLines, ImmutableArray<Attrib
                         continue;
                     }
 
-                    var arg = attribute.ConstructorArguments.FirstOrDefault();
+                    string args = String.Join(", ", attribute.ConstructorArguments.Select(a => GetTypedConstantValue(a)));
 
                     var attributeLine = new ReviewLine()
                     {
                         // GetId() is not unique for attribute class. for e.g. attribute class id is something like "System.FlagsAttribute"
                         // So, using a unique id for attribute line
-                        LineId = $"{attribute.AttributeClass.GetId()}({GetTypedConstantValue(arg)}).{relatedTo}",
+                        LineId = $"{attribute.AttributeClass.GetId()}({args}).{relatedTo}",
                         IsHidden = isHidden
                     };
 

tools/apiview/parsers/csharp-api-parser/CSharpAPIParserTests/CodeFileTests.cs

@@ -483,5 +483,44 @@ public IEnumerable<ISymbol> OrderMembers(IEnumerable<ISymbol> members)
                 }
             }
         }
+
+        [Fact]
+        public void TestInternalsVisibleToAttributes_WithDuplicateAssemblyUniquePublicKeys()
+        {
+            // Arrange
+            var lineIds = new HashSet<string>();
+            var sourceCode = @"
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo(""Microsoft.Azure.Cosmos.Client, PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9"")]
+[assembly: InternalsVisibleTo(""Microsoft.Azure.Cosmos.Client, PublicKey=0024000004800000940000000602000000240000525341310004000001000100197c25d0a04f73cb271e8181dba1c0c713df8deebb25864541a66670500f34896d280484b45fe1ff6c29f2ee7aa175d8bcbd0c83cc23901a894a86996030f6292ce6eda6e6f3e6c74b3c5a3ded4903c951e6747e6102969503360f7781bf8bf015058eb89b7621798ccc85aaca036ff1bc1556bb7f62de15908484886aa8bbae"")]
+
+namespace TestNamespace
+{
+    public class TestClass { }
+}";
+
+            var syntaxTree = Microsoft.CodeAnalysis.CSharp.CSharpSyntaxTree.ParseText(sourceCode);
+            var compilation = Microsoft.CodeAnalysis.CSharp.CSharpCompilation.Create(
+                "TestAssembly",
+                new[] { syntaxTree },
+                new[] { Microsoft.CodeAnalysis.MetadataReference.CreateFromFile(typeof(object).Assembly.Location) },
+                new Microsoft.CodeAnalysis.CSharp.CSharpCompilationOptions(Microsoft.CodeAnalysis.OutputKind.DynamicallyLinkedLibrary));
+
+            var assemblySymbol = compilation.Assembly;
+            var reviewLines = new List<APIView.Model.V2.ReviewLine>();
+
+            // Act
+            CSharpAPIParser.TreeToken.CodeFileBuilder.BuildInternalsVisibleToAttributes(reviewLines, assemblySymbol);
+
+            foreach (var line in reviewLines)
+            {
+                if (!string.IsNullOrEmpty(line.LineId))
+                {
+                    // Assert
+                    Assert.True(lineIds.Add(line.LineId), $"Duplicate LineId found: {line.LineId}");
+                }
+            }
+        }
     }
 }