Skip to content

Commit a036c97

Browse files
committed
fix(core): print warning instead of error
When runtime config is not valid Closes #489
1 parent 63951bd commit a036c97

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

src/core/utils/user-config.ts

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -311,28 +311,27 @@ function printSchemaValidationWarnings(filepath: string, data: SWAConfigFile | u
311311
sourceCodeWhereErrorHappened += chalk.grey(`${index}:`) + ` ${line}\n`;
312312
}
313313
}
314-
}
314+
logger.warn(`WARNING: Failed to read staticwebapp.config.json configuration from:\n ${filepath}\n`);
315+
let errorMessage = error?.message ?? "Unknown error";
316+
switch (error?.keyword) {
317+
case "enum":
318+
errorMessage = error?.message + " " + error.params.allowedValues.join(", ");
319+
break;
320+
case "type":
321+
errorMessage = error?.message!;
322+
break;
323+
case "required":
324+
errorMessage = `The property "${error?.params.missingProperty}" is required.`;
325+
break;
326+
case "additionalProperties":
327+
errorMessage = `The property "${error.params.additionalProperty}" is not allowed (Line: ${startLine})`;
328+
break;
329+
//TODO: add more cases
330+
}
331+
logger.warn(`The following error was encountered: ${errorMessage}`);
315332

316-
logger.warn(`WARNING: Failed to read staticwebapp.config.json configuration from:\n ${filepath}\n`);
317-
let errorMessage = error?.message ?? "Unknown error";
318-
switch (error?.keyword) {
319-
case "enum":
320-
errorMessage = error?.message + " " + error.params.allowedValues.join(", ");
321-
break;
322-
case "type":
323-
errorMessage = error?.message!;
324-
break;
325-
case "required":
326-
errorMessage = `The property "${error?.params.missingProperty}" is required.`;
327-
break;
328-
case "additionalProperties":
329-
errorMessage = `The property "${error.params.additionalProperty}" is not allowed`;
330-
break;
331-
//TODO: add more cases
333+
logger.warn(sourceCodeWhereErrorHappened);
334+
logger.warn(`Please fix the above error and try again to load and use the configuration.`);
335+
logger.warn(`Read more: https://aka.ms/swa/config-schema`);
332336
}
333-
logger.error(`The following error was encountered: ${errorMessage}`);
334-
335-
logger.warn(sourceCodeWhereErrorHappened);
336-
logger.warn(`Please fix the above error and try again to load and use the configuration.`);
337-
logger.warn(`Read more: https://aka.ms/swa/config-schema`);
338337
}

0 commit comments

Comments
 (0)