-
Notifications
You must be signed in to change notification settings - Fork 627
feat: ENG-9092 Correctly convert For loop in Mitosis JSX to repeat.collection in Builder JSON
#1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9a0ffe8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 9a0ffe8.
☁️ Nx Cloud last updated this comment at |
liamdebeasi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge once final comment is resolved. good job!
Description
Please provide the following information:
What changes you made:
Forloop in Mitosis JSX torepeat.collectionin Builder JSONWhy you made them, and:
Mitosis JSX
Currently the
Forloop in Mitosis JSX is converted to the following in Builder JSONBuilder JSON within a builder block
Which is not valid builder JSON, and it should be assigned a value in the
data.stateobject in Builder JSON. This PR corrects the conversion so that therepeat.collectionproperty is populated correctly.Any other useful context:
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.