Adding more test coverage and fixing minor issues

Author: CoreyKaylor

src/LightningDB.Tests/EnvironmentTests.cs

@@ -6,6 +6,14 @@ namespace LightningDB.Tests;
 
 public class EnvironmentTests : TestBase
 {
+    public void CanGetEnvironmentVersion()
+    {
+        using var env = CreateEnvironment();
+        var version = env.Version;
+        version.ShouldNotBeNull();
+        version.Minor.ShouldBeGreaterThan(0);
+    }
+
     public void EnvironmentShouldBeCreatedIfWithoutFlags()
     {
         using var env = CreateEnvironment();
@@ -101,6 +109,27 @@ public void EnvironmentShouldBeClosed()
         env.IsOpened.ShouldBeFalse();
     }
 
+    public void CanPutMultipleKeyValuePairsAndFlushSuccessfully()
+    {
+        using var env = CreateEnvironment();
+        env.Open();
+
+        using var tx = env.BeginTransaction();
+        using var db = tx.OpenDatabase(null, new DatabaseConfiguration { Flags = DatabaseOpenFlags.Create });
+
+        for (int i = 0; i < 5; i++)
+        {
+            var key = BitConverter.GetBytes(i);
+            var value = BitConverter.GetBytes(i * 10);
+            tx.Put(db, key, value);
+        }
+
+        tx.Commit();
+
+        var result = env.Flush(force: true);
+        result.ShouldBe(MDBResultCode.Success);
+    }
+
     public void EnvironmentShouldBeCopied()
     {
         void CopyTest(bool compact)

src/LightningDB.Tests/TransactionTests.cs

@@ -86,6 +86,41 @@ public void ChildTransactionShouldBeAbortedIfParentIsAborted()
             result.ShouldBe(MDBResultCode.BadTxn);
         });
     }
+    
+    public void TryGetShouldVerifyFindingAndNotFindingValues()
+    {
+        using var env = CreateEnvironment();
+        env.Open();
+        env.RunTransactionScenario((tx, db) =>
+        {
+            var key = MemoryMarshal.Cast<char, byte>("key1");
+            var value = MemoryMarshal.Cast<char, byte>("value1");
+    
+            tx.Put(db, key, value);
+    
+            tx.TryGet(db, key.ToArray(), out var retrievedValue).ShouldBeTrue();
+            retrievedValue.ShouldBe(value.ToArray());
+    
+            var missingKey = MemoryMarshal.Cast<char, byte>("key2");
+            tx.TryGet(db, missingKey.ToArray(), out _).ShouldBeFalse();
+        });
+    }
+    
+    public void TryGetWithKeyAndValueShouldBeFound()
+    {
+        using var env = CreateEnvironment();
+        env.Open();
+        env.RunTransactionScenario((tx, db) =>
+        {
+            var key = MemoryMarshal.Cast<char, byte>("key3");
+            var value = MemoryMarshal.Cast<char, byte>("value3");
+            tx.Put(db, key, value);
+    
+            var resultBuffer = new byte[value.Length];
+            tx.TryGet(db, key.ToArray(), resultBuffer).ShouldBeTrue();
+            resultBuffer.ShouldBe(value.ToArray());
+        });
+    }
 
     public void ChildTransactionShouldBeAbortedIfParentIsCommitted()
     {
@@ -228,4 +263,27 @@ public void TransactionShouldSupportCustomDupSorter()
                 BitConverter.ToInt32(result.Item3.CopyToNewArray()).ShouldBe(valuesSorted[order++]);
         }
     }
+    public void DatabaseShouldBeEmptyAfterTruncate()
+    {
+        using var env = CreateEnvironment();
+        env.Open();
+        env.RunTransactionScenario((tx, db) =>
+        {
+            // Insert several key-value pairs
+            var key1 = MemoryMarshal.Cast<char, byte>("key1");
+            var key2 = MemoryMarshal.Cast<char, byte>("key2");
+            var value1 = MemoryMarshal.Cast<char, byte>("value1");
+            var value2 = MemoryMarshal.Cast<char, byte>("value2");
+
+            tx.Put(db, key1, value1);
+            tx.Put(db, key2, value2);
+
+            // Truncate the database
+            tx.TruncateDatabase(db);
+
+            // Verify the database is empty
+            tx.ContainsKey(db, key1).ShouldBeFalse();
+            tx.ContainsKey(db, key2).ShouldBeFalse();
+        });
+    }
 }

src/LightningDB/LightningCursor.cs

@@ -12,7 +12,7 @@ namespace LightningDB;
 public class LightningCursor : IDisposable
 {
     private nint _handle;
-    private bool _disposed = false;
+    private bool _disposed;
 
     /// <summary>
     /// Creates new instance of LightningCursor
@@ -33,14 +33,6 @@ internal LightningCursor(LightningDatabase db, LightningTransaction txn)
         Transaction = txn;
     }
 
-    /// <summary>
-    /// Gets the native handle of the cursor
-    /// </summary>
-    public nint Handle()
-    {
-        return _handle;
-    }
-
     /// <summary>
     /// Cursor's transaction.
     /// </summary>
@@ -549,7 +541,8 @@ private void Dispose(bool disposing)
         }
         _handle = default;
 
-        GC.SuppressFinalize(this);
+        if(disposing)
+            GC.SuppressFinalize(this);
     }
 
     /// <summary>

src/LightningDB/LightningDatabase.cs

@@ -11,7 +11,7 @@ namespace LightningDB;
 public sealed class LightningDatabase : IDisposable
 {
     internal uint _handle;
-    private bool _disposed = false;
+    private bool _disposed;
     private readonly DatabaseConfiguration _configuration;
     private readonly bool _closeOnDispose;
     private readonly LightningTransaction _transaction;
@@ -101,7 +101,8 @@ private void Dispose(bool disposing)
         if (_closeOnDispose)
             mdb_dbi_close(Environment._handle, _handle);
 
-        GC.SuppressFinalize(this);
+        if(disposing)
+            GC.SuppressFinalize(this);
         _handle = default;
     }
 

src/LightningDB/LightningEnvironment.cs

@@ -12,7 +12,7 @@ namespace LightningDB;
 public sealed class LightningEnvironment : IDisposable
 {
     private readonly EnvironmentConfiguration _config = new();
-    private bool _disposed = false;
+    private bool _disposed;
 
     internal nint _handle;
 

src/LightningDB/LightningExtensions.cs

@@ -146,7 +146,7 @@ public static bool TryGet(this LightningTransaction tx, LightningDatabase db, Re
             value = mdbValue.CopyToNewArray();
             return true;
         }
-        value = default;
+        value = null;
         return false;
     }
 

src/LightningDB/LightningTransaction.cs

@@ -18,7 +18,7 @@ public sealed class LightningTransaction : IDisposable
 
     internal nint _handle;
     private readonly nint _originalHandle;
-    private bool _disposed = false;
+    private bool _disposed;
 
     /// <summary>
     /// Created new instance of LightningTransaction

src/LightningDB/Native/Lmdb.cs

@@ -106,8 +106,9 @@ public static partial class Lmdb
     [UnmanagedCallConv(CallConvs = [typeof(CallConvCdecl)])]
     public static partial MDBResultCode mdb_get(nint txn, uint dbi, ref MDBValue key, out MDBValue data);
 
-    [DllImport(MDB_DLL_NAME, CallingConvention = CallingConvention.Cdecl)]
-    public static extern MDBResultCode mdb_cursor_count(nint cursor, out int countp);
+    [LibraryImport(MDB_DLL_NAME)]
+    [UnmanagedCallConv(CallConvs = [typeof(CallConvCdecl)])]
+    public static partial MDBResultCode mdb_cursor_count(nint cursor, out int countp);
 
     [LibraryImport(MDB_DLL_NAME)]
     [UnmanagedCallConv(CallConvs = [typeof(CallConvCdecl)])]