Skip to content

Enhance benchmark.jl with BenchmarkTools and new scatter! function #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthieugomez wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance benchmark.jl with BenchmarkTools and new scatter! function #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd48d05
Enhance benchmark.jl with BenchmarkTools and new scatter! function
matthieugomez Feb 4, 2026
2b9c68d
Reduce chunk size in scatter and cache functions
matthieugomez Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion benchmarks/benchmark.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
using FixedEffects, Random, Statistics
using FixedEffects, Random, Statistics, BenchmarkTools, GroupedArrays
Random.seed!(1234)


function scatter!(y::AbstractVector, α::Number, fecoef::AbstractVector,
refs::AbstractVector, cache::AbstractVector; chunksize = 1_000_000)
GroupedArrays.@spawn_for_chunks chunksize for i in eachindex(y)
@inbounds y[i] += α * fecoef[refs[i]] * cache[i]
end
end

n = 10_000_000
N = 1_000_000
refs = rand(1:N, n)
fecoef = rand(N)
cache = rand(n)
y = zeros(n)
@btime scatter!(y, 1.0, fecoef, refs, cache; chunksize = 1_000_000)
@btime scatter!(y, 1.0, fecoef, refs, cache; chunksize = 100_000)



N = 10000000
K = 100
id1 = rand(1:div(N, K), N)
Expand Down
4 changes: 2 additions & 2 deletions src/SolverCPU.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ end

function scatter!(y::AbstractVector, α::Number, fecoef::AbstractVector,
refs::AbstractVector, cache::AbstractVector)
@spawn_for_chunks 1_000_000 for i in eachindex(y)
@spawn_for_chunks 100_000 for i in eachindex(y)
@inbounds y[i] += α * fecoef[refs[i]] * cache[i]
end
end
Expand Down Expand Up @@ -85,7 +85,7 @@ function scale!(scale::AbstractVector, refs::AbstractVector, interaction::Abstra
end

function cache!(cache::AbstractVector, refs::AbstractVector, interaction::AbstractVector, weights::AbstractVector, scale::AbstractVector)
@spawn_for_chunks 1_000_000 for i in eachindex(cache)
@spawn_for_chunks 100_000 for i in eachindex(cache)
@inbounds @fastmath cache[i] = interaction[i] * sqrt(weights[i]) * scale[refs[i]]
end
end
Expand Down