Fix CMake warning CMAKE_MINIMUM_REQUIRED #357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CMake warning about minimum_required declaration order
Issue
This PR fixes issue #341 where a CMake warning is triggered due to improper ordering of CMake commands.
Changes
CMAKE_MINIMUM_REQUIRED(VERSION 3.11)before theproject(VolEsti)declaration in test/CMakeLists.txtDetails
CMake best practices require that the minimum required version be declared before the project definition. This ensures proper policy settings and behavior consistency. This PR makes the minimal necessary change to fix the warning while maintaining project conventions.
Closes #341