Skip to content

Security fix: open redirect vulnerability in case of 'unknown client_id' #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seb-men wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security fix: open redirect vulnerability in case of 'unknown client_id' #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/pyop/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ def to_error_url(self):
return None


class UnknownClientId(InvalidAuthenticationRequest):
def to_error_url(self):
return None


class InvalidRedirectURI(InvalidAuthenticationRequest):
def to_error_url(self):
return None
Expand Down
3 changes: 2 additions & 1 deletion src/pyop/request_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from .exceptions import InvalidClientRegistrationRequest
from .exceptions import InvalidAuthenticationRequest
from .exceptions import UnknownClientId
from .exceptions import InvalidRedirectURI
from .util import is_allowed_response_type, find_common_values

Expand Down Expand Up @@ -32,7 +33,7 @@ def client_id_is_known(provider, authentication_request):
"""
if authentication_request['client_id'] not in provider.clients:
logger.error('Unknown client_id \'{}\''.format(authentication_request['client_id']))
raise InvalidAuthenticationRequest('Unknown client_id',
raise UnknownClientId('Unknown client_id',
authentication_request,
oauth_error='unauthorized_client')

Expand Down