Commit effb8ee
committed
Add label support to REVIEWERS and NOTIFIED files.
This lets you specify rules like this:
```
allfiles: **/* @notifyme
```
And when we add the NOTIFIED section to the github PR, it will now say:
```
@notifyme (allfiles): file1 file2 file3
```
(For rules without labels, the output is unchanged.)
This is helpful for knowing _why_ you were being notified for a
particular PR, since as we add more NOTIFIED rules it can get harder
to tell.
I added the support for REVIEWERS as well, since it was easy, though
I'm not sure how useful it is there.
While in the area, I couldn't help but clean up the existing code a
bit, especially simplifying some of the regexp-parsing logic (at the
cost of more parentheses in the regexp).
Issue: https://khanacademy.atlassian.net/browse/FEI-5970
Test plan:
yarn flow
yarn jest1 parent 6626012 commit effb8ee
File tree
7 files changed
+460
-402
lines changed- .github
- dist
- src
- __test__
7 files changed
+460
-402
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
10 | 14 | | |
11 | 15 | | |
12 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments