Commit 48f1df2
authored
minor #1007 Add comment on AbstractApi::$perPage() (Nyholm)
This PR was merged into the 3.3.x-dev branch.
Discussion
----------
The `AbstractApi::setPerPage()` was removed in the 3.0. I cannot find what PR that removed it.
However, we kept `AbstractApi::$perPage` and we do use it on a few places.. Im not sure if we should remove the property or add back the method.
Also note, some integration tests are using `setPerPage()`.
Commits
-------
aeeda19 Added comment on AbstractApi::$perPageFile tree
2 files changed
+1
-21
lines changed- lib/Github/Api
- test/Github/Tests/Integration
2 files changed
+1
-21
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 12 | | |
31 | 13 | | |
32 | 14 | | |
| |||
43 | 25 | | |
44 | 26 | | |
45 | 27 | | |
46 | | - | |
47 | 28 | | |
48 | 29 | | |
49 | | - | |
50 | 30 | | |
51 | 31 | | |
52 | 32 | | |
| |||
0 commit comments