Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Commit 263a673

Browse files
Remove test env from pipeline (#40)
* remove test env from pipeline * fix failing pipeline Signed-off-by: Ayman <[email protected]> Co-authored-by: Ayman <[email protected]>
1 parent 6a0ea7d commit 263a673

File tree

2 files changed

+7
-33
lines changed

2 files changed

+7
-33
lines changed

.circleci/config.yml

Lines changed: 6 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,15 @@ jobs:
3636
command: |
3737
eval "echo 'export AWS_ACCESS_KEY_ID=\$$AWS_ACCESS_KEY_ID_ENV_VAR'" >> $BASH_ENV
3838
eval "echo 'export AWS_SECRET_ACCESS_KEY=\$$AWS_SECRET_ACCESS_KEY_ENV_VAR'" >> $BASH_ENV
39-
eval "echo 'export AWS_ACCOUNT_ID=\$$AWS_ACCOUNT_ID_ENV_VAR'" >> $BASH_ENV
4039
eval "echo 'export AWS_DEFAULT_REGION=\$$AWS_REGION_ENV_VAR'" >> $BASH_ENV
4140
- run:
4241
name: Setup common environment variables
4342
command: |
44-
echo 'export FULL_IMAGE_NAME="${AWS_ACCOUNT_ID_ENV_VAR}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com/insights-connector-git:${TAG}"' >> $BASH_ENV
43+
echo 'export FULL_IMAGE_NAME="${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com/insights-connector-git:${TAG}"' >> $BASH_ENV
4544
- run:
4645
name: Authenticate ECR
4746
command: |
48-
aws ecr get-login-password | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID_ENV_VAR}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com
47+
aws ecr get-login-password | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com
4948
- run:
5049
name: setup the docker repository to be able to push image in aws (should succeed on first time & allowed to fail later)
5150
command: |
@@ -64,28 +63,15 @@ jobs:
6463
AWS_REGION_ENV_VAR: AWS_REGION_DEV
6564
AWS_ACCESS_KEY_ID_ENV_VAR: AWS_ACCESS_KEY_ID_DEV
6665
AWS_SECRET_ACCESS_KEY_ENV_VAR: AWS_SECRET_ACCESS_KEY_DEV
67-
AWS_ACCOUNT_ID_ENV_VAR: "395594542180"
6866
GITHUB_TOKEN: GITHUB_TOKEN
6967
STAGE: dev
7068
TAG: latest
7169

72-
deploy_test:
73-
<<: *deploy
74-
environment:
75-
AWS_ACCESS_KEY_ID_ENV_VAR: AWS_ACCESS_KEY_ID_TEST
76-
AWS_SECRET_ACCESS_KEY_ENV_VAR: AWS_SECRET_ACCESS_KEY_TEST
77-
AWS_ACCOUNT_ID_ENV_VAR: AWS_ACCOUNT_ID_TEST
78-
AWS_REGION_ENV_VAR: AWS_REGION_TEST
79-
GITHUB_TOKEN: GITHUB_TOKEN
80-
STAGE: test
81-
TAG: test
82-
8370
deploy_prod:
8471
<<: *deploy
8572
environment:
8673
AWS_ACCESS_KEY_ID_ENV_VAR: AWS_ACCESS_KEY_ID_PROD
8774
AWS_SECRET_ACCESS_KEY_ENV_VAR: AWS_SECRET_ACCESS_KEY_PROD
88-
AWS_ACCOUNT_ID_ENV_VAR: AWS_ACCOUNT_ID_PROD
8975
AWS_REGION_ENV_VAR: AWS_REGION_PROD
9076
GITHUB_TOKEN: GITHUB_TOKEN
9177
STAGE: prod
@@ -99,30 +85,15 @@ workflows:
9985
tags:
10086
only: /.*/
10187
- deploy_dev:
88+
context:
89+
- development
10290
requires:
10391
- build
10492
filters:
10593
branches:
10694
only: main
10795
tags:
10896
ignore: /.*/
109-
- approve_test:
110-
type: approval
111-
requires:
112-
- build
113-
filters:
114-
branches:
115-
ignore: /.*/
116-
tags:
117-
only: /^v\d+(\.\d+)?(\.\d+)?$/
118-
- deploy_test:
119-
requires:
120-
- approve_test
121-
filters:
122-
branches:
123-
ignore: /.*/
124-
tags:
125-
only: /^v\d+(\.\d+)?(\.\d+)?$/
12697
- approve_prod:
12798
type: approval
12899
requires:
@@ -133,6 +104,8 @@ workflows:
133104
tags:
134105
only: /^v\d+(\.\d+)?(\.\d+)?$/
135106
- deploy_prod:
107+
context:
108+
- production
136109
requires:
137110
- approve_prod
138111
filters:

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,4 @@ bin
3434
*.token
3535
*.secret
3636
*.log
37+
.idea

0 commit comments

Comments
 (0)