Skip to content

Commit 7cee62f

Browse files
author
David Collins
authored
Merge pull request #75 from GabrielePrestifilippo/master
Inline subtraction to avoid overwriting subtrahend
2 parents 379b594 + 97cac4b commit 7cee62f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/geom/Vec3.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ define([
125125
Logger.logMessage(Logger.LEVEL_SEVERE, "Vec3", "areColinear", "missingVector"));
126126
}
127127

128-
var ab = b.subtract(a).normalize(),
129-
bc = c.subtract(b).normalize();
128+
var ab = new Vec3(a[0]-b[0],a[1]-b[1],a[2]-b[2]).normalize(),
129+
bc = new Vec3(c[0]-b[0],c[1]-b[1],c[2]-b[2]).normalize();
130130

131131
// ab and bc are considered colinear if their dot product is near +/-1.
132132
return Math.abs(ab.dot(bc)) > 0.999;

0 commit comments

Comments
 (0)