Skip to content

Conversation

@GaetanSantucci
Copy link
Member

@GaetanSantucci GaetanSantucci commented Dec 3, 2025

Into the InjectorContract add the link to retrieve the associated domains
Into the InjectorContract add domain selector to create and update into

Testing Instructions

  1. In the Injectors, you can choose an inject, create an injector contract and now you must add or update a domain to it, which is mandatory. You can do this only on injector if it's not an payload type injector
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

On the front end, I've decided to continue with legacy JS code; it would be necessary to refactor it using TS/React-Hook-Form and reuse the DomainFieldController component.

@GaetanSantucci GaetanSantucci added feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team labels Dec 3, 2025
@GaetanSantucci GaetanSantucci self-assigned this Dec 3, 2025
@savacano28 savacano28 changed the title [backend/frontend] feat(scv): Implement domains to injector contract (#4477) [backend/frontend] feat(scv): implement domains to injector contract (#4477) Dec 4, 2025
@savacano28 savacano28 removed the feature use for describing a new feature to develop label Dec 4, 2025
@GaetanSantucci GaetanSantucci marked this pull request as ready for review December 4, 2025 16:16
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.90%. Comparing base (267049f) to head (0701b50).

Files with missing lines Patch % Lines
...est/injector_contract/InjectorContractService.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4492      +/-   ##
=====================================================
+ Coverage              50.89%   50.90%   +0.01%     
- Complexity              3762     3763       +1     
=====================================================
  Files                    914      914              
  Lines                  27396    27403       +7     
  Branches                2059     2060       +1     
=====================================================
+ Hits                   13942    13949       +7     
+ Misses                 12608    12607       -1     
- Partials                 846      847       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

.whenIgnoringPaths(
"injector_contract_created_at",
"injector_contract_updated_at",
"injector_contract_domains")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to test the domains, and only ignore the dates on domains ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants