-
Notifications
You must be signed in to change notification settings - Fork 173
[backend/frontend] feat(scv): implement domains to injector contract (#4477) #4492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/current
Are you sure you want to change the base?
Conversation
6cbb016 to
1bd5ae3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #4492 +/- ##
=====================================================
+ Coverage 50.89% 50.90% +0.01%
- Complexity 3762 3763 +1
=====================================================
Files 914 914
Lines 27396 27403 +7
Branches 2059 2060 +1
=====================================================
+ Hits 13942 13949 +7
+ Misses 12608 12607 -1
- Partials 846 847 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openaev-api/src/main/java/io/openaev/rest/domain/DomainService.java
Outdated
Show resolved
Hide resolved
| .whenIgnoringPaths( | ||
| "injector_contract_created_at", | ||
| "injector_contract_updated_at", | ||
| "injector_contract_domains") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to test the domains, and only ignore the dates on domains ?
openaev-front/src/admin/components/integrations/injectors/InjectorContracts.js
Outdated
Show resolved
Hide resolved
...src/admin/components/integrations/injectors/injector_contracts/InjectorContractCustomForm.js
Outdated
Show resolved
Hide resolved
...front/src/admin/components/integrations/injectors/injector_contracts/InjectorContractForm.js
Show resolved
Hide resolved
b721bf3 to
b50ad88
Compare
Into the InjectorContract add the link to retrieve the associated domains
Into the InjectorContract add domain selector to create and update into
Testing Instructions
Related issues
Checklist
Further comments
On the front end, I've decided to continue with legacy JS code; it would be necessary to refactor it using TS/React-Hook-Form and reuse the DomainFieldController component.