Merge back 'chore_release-8.8.0' into 'chore_release-pd-8.7.0' #20304
+248
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20022) # Overview The aspirate/dispense while tracking has to propagate the right type of overpressure error.
## Overview This fixes robot-server's `/redoc` page not loading. Closes RQA-4929. ## Test Plan and Hands on Testing * [x] `make -C robot-server dev` still boots * [x] Visiting http://localhost:31950/redoc shows HTTP API documentation again ## Changelog robot-server serves documentation for its HTTP API at `/redoc`. The way that works is that FastAPI serves a minimal static HTML file that loads the [Redoc](https://github.com/Redocly/redoc) JavaScript bundle from a CDN. The JavaScript bundle then fetches `./openapi.json`, extracts information about the HTTP API, and builds the actual page. In our version of FastAPI, the Redoc CDN link is https://cdn.jsdelivr.net/npm/redoc@next/bundles/redoc.standalone.js. This started 404ing recently, for reasons that probably have to do with [the `@next` version tag being problematic](Redocly/redoc#2743), causing the `/redoc` page to just show a white screen. [Newer versions of FastAPI use `@2` instead.](fastapi/fastapi#9700) The workaround here is to override the CDN URL to `@2` [following FastAPI's recommended pattern](https://fastapi.tiangolo.com/how-to/custom-docs-ui-assets/#custom-cdn-for-javascript-and-css).
# Overview Adds a known issue (reported in [RQA-4939 ](https://opentrons.atlassian.net/browse/RQA-4939)) to the 8.8. release notes. ## Test Plan and Hands on Testing ## Changelog One-line change to the app release notes. ## Review requests Does this cover the issue? Added that we would recommend canceling, as the flow is: - error recovery _does_ launch - users can click **retry** or **cancel** - "retry" will run but never succeed - ## Risk assessment low.
# Overview adds a description of a known issue (described [here](https://opentrons.slack.com/archives/C09LFJJMUD8/p1764873415007959)) with accessing camera images during a run via USB. ## Test Plan and Hands on Testing ## Changelog one-line addition to known issues in app release notes. ## Review requests ## Risk assessment low.
ddcc4
requested review from
CaseyBatten,
SyntaxColoring,
emilyburghardt and
jerader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes @ryanthecoder and @SyntaxColoring's changes to RS 8.8.0.