-
Notifications
You must be signed in to change notification settings - Fork 170
Implementing FieldSet.from_nemo() #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
92260d4
First implementation of fieldset.from_nemo
erikvansebille 7c08dff
Setting vector_interp_method only when vector fields available
erikvansebille b1d6692
Add error when pset.execute has neither runtime nor endtime
erikvansebille 4402082
Adding support for NEMO 3D
erikvansebille e5c87b0
Fixing negating vertical velocity code
erikvansebille 6329764
Adding docstring for from_nemo
erikvansebille 9ac595f
Support for NEMO fields without depth
erikvansebille 4d3f627
Simplifying nemo dataset creation in tutorial
erikvansebille 2d9640e
Always attach a UV Field
erikvansebille 2d40335
Using glamf, gphif and depth as dimensions in from_nemo
erikvansebille 7e568ff
Fixing test
erikvansebille 5850b6a
Using xgcm coordinates for cgrid interpolation selection
erikvansebille 494d9d8
Reordering corner_data in CGrid_Velocity
erikvansebille 877ac6b
Separating U and V interpolation in CGrid_Velocity
erikvansebille d8c7df1
Cleaning up CGrid_Velocity code
erikvansebille 3216cf5
Fixing bug in CGrid_Tracer interpolation
erikvansebille dafe9f3
Using offsets in CGrid_Tracer
erikvansebille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this
is the way to go.
from_nemoresults in variables (e.g., U and V) which are both defined on dimensions named x and y to be considered to be defined on the same points rather than on a staggered gridfrom_nemoreturn a fieldset instead of the dataset prevents the user from making additional changes to the dataset (e.g., fixing their metadata)I think a better API would be to have
from_nemotake in datasets, and then merge them together under the hood. This way we know that the origin datasets are different and can treat them accordingly (i.e., stagger them). If this then returns a dataset then the user can edit and slice further.