unifed api: stt sarvam #579

coderabbitai · 2026-02-04T15:38:44Z

⚠️ Potential issue | 🟡 Minor

Fix the revision header to match the revision variables.
The header says “Revision ID: 041” and “Revises: 040” while the actual revision = "042" and down_revision = "041". This mismatch is confusing and suggests the migration wasn’t generated with the expected rev‑id.

🔧 Suggested header fix

-Revision ID: 041 -Revises: 040 +Revision ID: 042 +Revises: 041

Based on learnings: Generate database migrations using alembic revision --autogenerate -m "Description" --rev-id <number> where rev-id is the latest existing revision ID + 1.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

"""add_llm_call_table

Revision ID: 041

Revises: 040

Create Date: 2026-01-26 15:20:23.873332

"""

from alembic import op

import sqlalchemy as sa

import sqlmodel.sql.sqltypes

from sqlalchemy.dialects import postgresql

# revision identifiers, used by Alembic.

revision = "042"

down_revision = "041"

branch_labels = None

"""add_llm_call_table

Revision ID: 042

Revises: 041

Create Date: 2026-01-26 15:20:23.873332

"""

from alembic import op

import sqlalchemy as sa

import sqlmodel.sql.sqltypes

from sqlalchemy.dialects import postgresql

# revision identifiers, used by Alembic.

revision = "042"

down_revision = "041"

branch_labels = None

🤖 Prompt for AI Agents

In `@backend/app/alembic/versions/042_add_llm_call_table.py` around lines 1 - 16, Update the module header docstring so the human-readable Revision ID and Revises lines match the actual alembic variables: change the header "Revision ID: 041" to "Revision ID: 042" and "Revises: 040" to "Revises: 041" to align with the `revision = "042"` and `down_revision = "041"` values in this migration file (look for the top-of-file docstring and the `revision`/`down_revision` symbols).

coderabbitai · 2026-02-04T15:38:44Z

⚠️ Potential issue | 🟡 Minor

Add return type hints for upgrade and downgrade.
These functions should be explicitly annotated to satisfy the project’s typing requirement.

✅ Suggested fix

-def upgrade(): +def upgrade() -> None: @@ -def downgrade(): +def downgrade() -> None:

As per coding guidelines: Always add type hints to all function parameters and return values in Python code.

Also applies to: 164-165

🤖 Prompt for AI Agents

In `@backend/app/alembic/versions/042_add_llm_call_table.py` around lines 20 - 21, Add explicit return type annotations to the Alembic migration functions: annotate both upgrade() and downgrade() with -> None (e.g., def upgrade() -> None: and def downgrade() -> None:) so they satisfy the project's typing requirements; update the function signatures where upgrade and downgrade are defined in this migration file.

coderabbitai · 2026-02-04T15:38:44Z

⚠️ Potential issue | 🟡 Minor

Potential typo in the column comment: -native may be incomplete.

The comment "AI provider as sent by user (e.g openai, -native, google)" contains -native which appears incomplete. Should this be openai-native or google-native based on the provider naming convention?

Suggested fix (if `openai-native` was intended)

op.alter_column( "llm_call", "provider", existing_type=sa.VARCHAR(), - comment="AI provider as sent by user (e.g openai, -native, google)", + comment="AI provider as sent by user (e.g. openai, openai-native, google)", existing_comment="AI provider: openai, google, anthropic", existing_nullable=False, )

🤖 Prompt for AI Agents

In `@backend/app/alembic/versions/043_remove_enum_checks_llm_call_provider.py` around lines 20 - 30, The column comment on the "provider" column in the upgrade() migration contains a likely typo ("AI provider as sent by user (e.g openai, -native, google)"); update the comment to the correct provider token (e.g. "AI provider as sent by user (e.g. openai, openai-native, google)" or whichever canonical name is used) inside the op.alter_column call in upgrade(), ensuring the existing_comment/existing_type/nullable parameters remain unchanged and only the comment string is corrected.

coderabbitai · 2026-02-04T15:38:44Z

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# Find _validate_immutable_fields implementation rg -n -A 25 "_validate_immutable_fields" --type=py backend/

Repository: ProjectTech4DevAI/kaapi-backend

Length of output: 4079

🏁 Script executed:

# Find ConfigVersionCreatePartial model definition rg -n -B 5 -A 15 "class ConfigVersionCreatePartial" --type=py backend/

Repository: ProjectTech4DevAI/kaapi-backend

Length of output: 1662

🏁 Script executed:

# Check the version.py file to understand the context better cat -n backend/app/api/routes/config/version.py | head -50

Repository: ProjectTech4DevAI/kaapi-backend

Length of output: 1966

Correct the ConfigVersionCreatePartial model docstring to accurately reflect immutable fields.

The route docstring correctly states "Provider, model, and params can be changed. Type is inherited from existing config and cannot be changed," which matches the actual behavior in _validate_immutable_fields (which only validates type immutability). However, the ConfigVersionCreatePartial model docstring in backend/app/models/config/version.py incorrectly claims that both "provider and type are inherited... and cannot be changed" when in fact only type is immutable. Update the model docstring to reflect that provider and type have different mutability constraints.

🤖 Prompt for AI Agents

In `@backend/app/api/routes/config/version.py` around lines 31 - 41, Update the ConfigVersionCreatePartial model docstring in backend/app/models/config/version.py to correctly state immutability: change the incorrect sentence that says "provider and type are inherited... and cannot be changed" to reflect that only "type is inherited from the existing config and cannot be changed," while "provider, model, and params can be changed"; ensure the docstring on the ConfigVersionCreatePartial class matches the route docstring and the behavior enforced by _validate_immutable_fields.

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
     from app.api.deps import SessionDep, AuthContextDep
     from app.crud.config import ConfigCrud, ConfigVersionCrud
     from app.models import (
-        ConfigVersionCreate,
+        ConfigVersionCreatePartial,
         ConfigVersionPublic,
         Message,
         ConfigVersionItems,
@@ Expand All / @@ -24,18 +24,21 @@ @@
     )
     def create_version(
         config_id: UUID,
-        version_create: ConfigVersionCreate,
+        version_create: ConfigVersionCreatePartial,
         current_user: AuthContextDep,
         session: SessionDep,
     ):
         """
         Create a new version for an existing configuration.
-        The version number is automatically incremented.
+        Only include the fields you want to update in config_blob.
+        Provider, model, and params can be changed.
+        Type is inherited from existing config and cannot be changed.
         """
         version_crud = ConfigVersionCrud(
             session=session, project_id=current_user.project_.id, config_id=config_id
         )
-        version = version_crud.create_or_raise(version_create=version_create)
+        version = version_crud.create_from_partial_or_raise(version_create=version_create)
         return APIResponse.success_response(
             data=ConfigVersionPublic(**version.model_dump()),
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -1,6 +1,7 @@
     """
     Celery beat scheduler for cron jobs.
     """
     import logging
     from celery import Celery
     from app.celery.celery_app import celery_app
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     Utility functions for easy Celery integration across the application.
     Business logic modules can use these functions without knowing Celery internals.
     """
     import logging
     from typing import Any, Dict, Optional
     from celery.result import AsyncResult
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -1,6 +1,7 @@
     """
     Celery worker management script.
     """
     import logging
     import multiprocessing
     from celery.bin import worker
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -210,7 +210,7 @@ def send_benchmark_request( @@
             )
         else:
             typer.echo(response.text)
-            typer.echo(f"[{i+1}/{total}] FAILED - Status: {response.status_code}")
+            typer.echo(f"[{i + 1}/{total}] FAILED - Status: {response.status_code}")
             raise Exception(f"Request failed with status code {response.status_code}")
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unifed api: stt sarvam #579

Uh oh!

Diff view

Diff view

There are no files selected for viewing

coderabbitai bot Feb 4, 2026

Uh oh!

coderabbitai bot Feb 4, 2026

Uh oh!

coderabbitai bot Feb 4, 2026

Uh oh!

coderabbitai bot Feb 4, 2026

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ -0,0 +1,43 @@
+    """remove:enum checks llm_call provider
+    Revision ID: 043
+    Revises: 042
+    Create Date: 2026-01-30 11:22:45.165543
+    """
+    from alembic import op
+    import sqlalchemy as sa
+    import sqlmodel.sql.sqltypes
+    # revision identifiers, used by Alembic.
+    revision = "043"
+    down_revision = "042"
+    branch_labels = None
+    depends_on = None
+    def upgrade():
+        # ### commands auto generated by Alembic - please adjust! ###
+        op.alter_column(
+            "llm_call",
+            "provider",
+            existing_type=sa.VARCHAR(),
+            comment="AI provider as sent by user (e.g openai, -native, google)",
+            existing_comment="AI provider: openai, google, anthropic",
+            existing_nullable=False,
+        )
+        # ### end Alembic commands ###
+    def downgrade():
+        # ### commands auto generated by Alembic - please adjust! ###
+        op.alter_column(
+            "llm_call",
+            "provider",
+            existing_type=sa.VARCHAR(),
+            comment="AI provider: openai, google, anthropic",
+            existing_comment="AI provider as sent by user (e.g openai, -native, google)",
+            existing_nullable=False,
+        )
+        # ### end Alembic commands ###

-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,8 @@ class Provider(str, Enum): @@
         OPENAI = "openai"
         AWS = "aws"
         LANGFUSE = "langfuse"
+        GOOGLE = "google"
+        SARVAMAI = "sarvamai"
     @dataclass
@@ Expand All / @@ -30,21 +32,12 @@ class ProviderConfig: @@
         Provider.LANGFUSE: ProviderConfig(
             required_fields=["secret_key", "public_key", "host"]
         ),
+        Provider.GOOGLE: ProviderConfig(required_fields=["api_key"]),
+        Provider.SARVAMAI: ProviderConfig(required_fields=["api_key"]),
     }
     def validate_provider(provider: str) -> Provider:
-        """Validate that the provider name is supported and return the Provider enum.
-        Args:
-            provider: The provider name to validate
-        Returns:
-            Provider: The validated provider enum
-        Raises:
-            ValueError: If the provider is not supported
-        """
         try:
             return Provider(provider.lower())
         except ValueError:
@@ Expand Down @@

unifed api: stt sarvam #579

Are you sure you want to change the base?

Uh oh!

unifed api: stt sarvam #579

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

coderabbitai bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!