[INTERNAL] Fix tests

Author: matz3

lib/index.js

@@ -15,8 +15,6 @@ const ImportCollectorPlugin = require("./plugin/import-collector");
 const VariableCollectorPlugin = require("./plugin/variable-collector");
 const UrlCollector = require("./plugin/url-collector");
 
-const LESS_OPENUI5_VERSION = require("../package.json").version;
-
 // Workaround for a performance issue in the "css" parser module when used in combination
 // with the "colors" module that enhances the String prototype.
 // See: https://github.com/reworkcss/css/issues/88
@@ -72,6 +70,15 @@ const Builder = function(options) {
 	this.fileUtils = fileUtilsFactory(this.customFs);
 };
 
+let engineInfo;
+Builder.getEngineInfo = function() {
+	if (!engineInfo) {
+		const {name, version} = require("../package.json");
+		engineInfo = {name, version};
+	}
+	return engineInfo;
+};
+
 Builder.prototype.getThemeCache = function(rootPath) {
 	return this.themeCacheMapping[rootPath];
 };
@@ -375,18 +382,19 @@ Builder.prototype.build = function(options) {
 			// TODO: How to get theme name? .theming "sId"? parse from file path? new parameter?
 			const themeId = "<theme-name>";
 
+			const {version, name} = Builder.getEngineInfo();
 			const metadataJson = JSON.stringify({
-				"Path": `UI5.${libraryNameSlashed}.${themeId}.library`,
-				"PathPattern": "/%frameworkId%/%libId%/themes/%themeId%/%fileId%.css",
-				"Extends": ["base"], // TODO: Read from .theming?
-				"Scopes": scopes,
-				"Engine": {
-					"Version": LESS_OPENUI5_VERSION,
-					"Name": "less-openui5"
+				Path: `UI5.${libraryNameSlashed}.${themeId}.library`,
+				PathPattern: "/%frameworkId%/%libId%/themes/%themeId%/%fileId%.css",
+				Extends: ["base"], // TODO: Read from .theming?
+				Scopes: scopes,
+				Engine: {
+					Version: version,
+					Name: name
 				},
-				"Version": {
-					"Build": "<TODO>", // TOOD: add new property options.library.version
-					"Source": "<TODO>" // TOOD: add new property options.library.version
+				Version: {
+					Build: "<TODO>", // TOOD: add new property options.library.version
+					Source: "<TODO>" // TOOD: add new property options.library.version
 				}
 			});
 
@@ -656,3 +664,11 @@ Builder.prototype.build = function(options) {
 };
 
 module.exports.Builder = Builder;
+
+// Set engine info during unit test execution to have a static version that can be used in the expected build results
+if (process.env.NODE_ENV === "test") {
+	engineInfo = {
+		name: "less-openui5",
+		version: "0.0.0-test"
+	};
+}

package.json

@@ -23,8 +23,8 @@
 	},
 	"scripts": {
 		"lint": "eslint ./",
-		"unit": "mocha test/*.js",
-		"unit-debug": "mocha --inspect --inspect-brk test/*.js",
+		"unit": "NODE_ENV=test mocha test/*.js",
+		"unit-debug": "NODE_ENV=test mocha --inspect --inspect-brk test/*.js",
 		"coverage": "nyc npm run unit",
 		"test": "npm run lint && npm run coverage && npm run depcheck",
 		"preversion": "npm test",

test/expected/inlineCssVariables/lib3/my/other/ui/lib/themes/base/library-RTL.css

@@ -1,7 +1,7 @@
 
 :root {
   --sapUiTheme-my-other-ui-lib: true;
-  --sapThemeMetaData-UI5-my-other-ui-lib: {"Path":"UI5.my/other/ui/lib.<theme-name>.library","PathPattern":"/%frameworkId%/%libId%/themes/%themeId%/%fileId%.css","Extends":["base"],"Scopes":[],"Engine":{"Version":"0.11.1","Name":"less-openui5"},"Version":{"Build":"<TODO>","Source":"<TODO>"}};
+  --sapThemeMetaData-UI5-my-other-ui-lib: {"Path":"UI5.my/other/ui/lib.<theme-name>.library","PathPattern":"/%frameworkId%/%libId%/themes/%themeId%/%fileId%.css","Extends":["base"],"Scopes":[],"Engine":{"Version":"0.0.0-test","Name":"less-openui5"},"Version":{"Build":"<TODO>","Source":"<TODO>"}};
 }
 :root {
   --_my_other_ui_lib_MyControl_color1: var(--color1);

test/expected/inlineCssVariables/lib3/my/other/ui/lib/themes/base/library.css

@@ -1,7 +1,7 @@
 
 :root {
   --sapUiTheme-my-other-ui-lib: true;
-  --sapThemeMetaData-UI5-my-other-ui-lib: {"Path":"UI5.my/other/ui/lib.<theme-name>.library","PathPattern":"/%frameworkId%/%libId%/themes/%themeId%/%fileId%.css","Extends":["base"],"Scopes":[],"Engine":{"Version":"0.11.1","Name":"less-openui5"},"Version":{"Build":"<TODO>","Source":"<TODO>"}};
+  --sapThemeMetaData-UI5-my-other-ui-lib: {"Path":"UI5.my/other/ui/lib.<theme-name>.library","PathPattern":"/%frameworkId%/%libId%/themes/%themeId%/%fileId%.css","Extends":["base"],"Scopes":[],"Engine":{"Version":"0.0.0-test","Name":"less-openui5"},"Version":{"Build":"<TODO>","Source":"<TODO>"}};
 }
 :root {
   --_my_other_ui_lib_MyControl_color1: var(--color1);

test/expected/libraries/lib1/my/ui/lib/themes/foo/css_variables.css

@@ -1,6 +1,7 @@
 :root {
   --color1: #ffffff;
   --url1: url('../base/111');
+  --url1__asResolvedUrl: "ui5://my/ui/lib/themes/base/111";
 }
 .fooContrast {
   --color1: #000000;

test/expected/libraries/lib1/my/ui/lib/themes/foo/css_variables.source.less

@@ -1,7 +1,9 @@
 @color1: #ffffff;
 @url1: url('../base/111');
+@url1__asResolvedUrl: "ui5://my/ui/lib/themes/base/111";
 
 :root {
 --color1: @color1;
 --url1: @url1;
+--url1__asResolvedUrl: @url1__asResolvedUrl;
 }