add page url and source if some element was not found

Author: asolntsev

rb/lib/selenium/webdriver/common/wait.rb

@@ -37,7 +37,8 @@ def initialize(opts = {})
         @timeout  = opts.fetch(:timeout, DEFAULT_TIMEOUT)
         @interval = opts.fetch(:interval, DEFAULT_INTERVAL)
         @message  = opts[:message]
-        @ignored  = Array(opts[:ignore] || Error::NoSuchElementError)
+        @message_provider = opts[:message_provider]
+        @ignored = Array(opts[:ignore] || Error::NoSuchElementError)
       end
 
       #
@@ -64,6 +65,8 @@ def until
 
         msg = if @message
                 @message.dup
+              elsif @message_provider
+                @message_provider.call
               else
                 "timed out after #{@timeout} seconds"
               end

rb/spec/integration/selenium/webdriver/element_spec.rb

@@ -32,7 +32,7 @@ module WebDriver
       # Safari returns "click intercepted" error instead of "element click intercepted"
       it 'raises if different element receives click', except: {browser: %i[safari safari_preview]} do
         driver.navigate.to url_for('click_tests/overlapping_elements.html')
-        element = wait_for_element(id: 'contents')
+        element = wait_for_element(id: 'contents', timeout: 10)
         expect { element.click }.to raise_error(Error::ElementClickInterceptedError)
       end
 

rb/spec/integration/selenium/webdriver/spec_support/helpers.rb

@@ -84,8 +84,12 @@ def wait_for_no_alert
           wait.until { driver.title }
         end
 
-        def wait_for_element(locator)
-          wait = Wait.new(timeout: 25, ignore: Error::NoSuchElementError)
+        def wait_for_element(locator, timeout = 25)
+          wait = Wait.new(timeout: timeout, ignore: Error::NoSuchElementError, message_provider: lambda {
+            url = "page url: #{driver.current_url};\n"
+            source = "page source: #{driver.find_element(css: 'body').attribute('innerHTML')}\n"
+            "could not find element #{locator} in #{timeout} seconds;\n#{url}#{source}"
+          })
           wait.until { driver.find_element(locator) }
         end