use better AssertJ assertion for collection size

`assertThat($$.size()).isEqualTo(2)` -> `assertThat($$).hasSize(2)`

Author: asolntsev

java/test/org/openqa/selenium/ChildrenFindingTest.java

@@ -42,7 +42,7 @@ void testFindingElementsOnElementByXPathShouldFindTopLevelElements() {
     WebElement parent = driver.findElement(By.id("multiline"));
     List<WebElement> allPs = driver.findElements(By.xpath("//p"));
     List<WebElement> children = parent.findElements(By.xpath("//p"));
-    assertThat(allPs.size()).isEqualTo(children.size());
+    assertThat(allPs).hasSize(children.size());
   }
 
   @Test

java/test/org/openqa/selenium/CookieImplementationTest.java

@@ -119,7 +119,7 @@ public void testGetAllCookies() {
 
     openAnotherPage();
     cookies = driver.manage().getCookies();
-    assertThat(cookies.size()).isEqualTo(countBefore + 2);
+    assertThat(cookies).hasSize(countBefore + 2);
 
     assertThat(cookies.contains(one)).isTrue();
     assertThat(cookies.contains(two)).isTrue();

java/test/org/openqa/selenium/ElementFindingTest.java

@@ -708,7 +708,7 @@ void testShouldNotBeAbleToLocateByLinkTextMultipleElementsThatDoNotExist() {
   void testShouldBeAbleToFindMultipleElementsByPartialLinkText() {
     driver.get(pages.xhtmlTestPage);
     List<WebElement> elements = driver.findElements(By.partialLinkText("ick me"));
-    assertThat(elements.size()).isEqualTo(2);
+    assertThat(elements).hasSize(2);
   }
 
   @Test

java/test/org/openqa/selenium/WebScriptExecuteTest.java

@@ -212,7 +212,7 @@ void canExecuteScriptWithArrayArgument() {
 
     assertThat(value.getType()).isEqualTo("array");
     List<RemoteValue> values = (List<RemoteValue>) value.getValue().get();
-    assertThat(values.size()).isEqualTo(2);
+    assertThat(values).hasSize(2);
   }
 
   @Test
@@ -235,7 +235,7 @@ void canExecuteScriptWithSetArgument() {
 
     assertThat(value.getType()).isEqualTo("set");
     List<RemoteValue> values = (List<RemoteValue>) value.getValue().get();
-    assertThat(values.size()).isEqualTo(2);
+    assertThat(values).hasSize(2);
   }
 
   @Test
@@ -276,7 +276,7 @@ void canExecuteScriptWithMapArgument() {
     assertThat(value.getType()).isEqualTo("map");
 
     Map<Object, RemoteValue> values = (Map<Object, RemoteValue>) value.getValue().get();
-    assertThat(values.size()).isEqualTo(2);
+    assertThat(values).hasSize(2);
   }
 
   @Test
@@ -299,7 +299,7 @@ void canExecuteScriptWithObjectArgument() {
     assertThat(value.getType()).isEqualTo("object");
 
     Map<Object, RemoteValue> values = (Map<Object, RemoteValue>) value.getValue().get();
-    assertThat(values.size()).isEqualTo(6);
+    assertThat(values).hasSize(6);
   }
 
   @Test

java/test/org/openqa/selenium/WebScriptTest.java

@@ -56,7 +56,7 @@ void canAddConsoleMessageHandler()
     ConsoleLogEntry logEntry = future.get(5, TimeUnit.SECONDS);
 
     assertThat(logEntry.getText()).isEqualTo("Hello, world!");
-    assertThat(logEntry.getArgs().size()).isEqualTo(1);
+    assertThat(logEntry.getArgs()).hasSize(1);
     assertThat(logEntry.getArgs().get(0).getType()).isEqualTo("string");
     assertThat(logEntry.getType()).isEqualTo("console");
     assertThat(logEntry.getLevel()).isEqualTo(LogLevel.INFO);

java/test/org/openqa/selenium/bidi/browsingcontext/LocateNodesTest.java

@@ -49,7 +49,7 @@ void canLocateNodes() {
     LocateNodeParameters parameters = new LocateNodeParameters(Locator.css("div"));
 
     List<RemoteValue> elements = browsingContext.locateNodes(parameters);
-    assertThat(elements.size()).isEqualTo(13);
+    assertThat(elements).hasSize(13);
   }
 
   @Test
@@ -61,7 +61,7 @@ void canLocateNodesWithJustLocator() {
     driver.get(pages.xhtmlTestPage);
 
     List<RemoteValue> elements = browsingContext.locateNodes(Locator.css("div"));
-    assertThat(elements.size()).isEqualTo(13);
+    assertThat(elements).hasSize(13);
   }
 
   @Test
@@ -95,7 +95,7 @@ void canLocateNodesWithCSSLocator() {
     assertThat(value.getValue().isPresent()).isTrue();
     NodeProperties properties = (NodeProperties) value.getValue().get();
     assertThat(properties.getLocalName().get()).isEqualTo("div");
-    assertThat(properties.getAttributes().get().size()).isEqualTo(1);
+    assertThat(properties.getAttributes().get()).hasSize(1);
     assertThat(properties.getAttributes().get().get("class")).isEqualTo("content");
   }
 
@@ -118,7 +118,7 @@ void canLocateNodesWithXPathLocator() {
     assertThat(value.getValue().isPresent()).isTrue();
     NodeProperties properties = (NodeProperties) value.getValue().get();
     assertThat(properties.getLocalName().get()).isEqualTo("div");
-    assertThat(properties.getAttributes().get().size()).isEqualTo(1);
+    assertThat(properties.getAttributes().get()).hasSize(1);
     assertThat(properties.getAttributes().get().get("class")).isEqualTo("content");
   }
 
@@ -154,7 +154,7 @@ void canLocateNodesWithMaxNodeCount() {
         new LocateNodeParameters(Locator.css("div")).setMaxNodeCount(4);
 
     List<RemoteValue> elements = browsingContext.locateNodes(parameters);
-    assertThat(elements.size()).isEqualTo(4);
+    assertThat(elements).hasSize(4);
   }
 
   @Test
@@ -193,7 +193,7 @@ void canLocateNodesGivenStartNodes() {
             .setMaxNodeCount(50);
 
     List<RemoteValue> elements = browsingContext.locateNodes(parameters);
-    assertThat(elements.size()).isEqualTo(35);
+    assertThat(elements).hasSize(35);
   }
 
   @Test
@@ -209,7 +209,7 @@ void canLocateNodesInAGivenSandbox() {
         new LocateNodeParameters(Locator.css("div")).setSandbox(sandbox).setMaxNodeCount(1);
 
     List<RemoteValue> elements = browsingContext.locateNodes(parameters);
-    assertThat(elements.size()).isEqualTo(1);
+    assertThat(elements).hasSize(1);
 
     String nodeId = elements.get(0).getSharedId().get();
 

java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java

@@ -56,7 +56,7 @@ void canListenToConsoleLog() throws ExecutionException, InterruptedException, Ti
       assertThat(source.getBrowsingContext().isPresent()).isTrue();
       assertThat(source.getRealm()).isNotNull();
       assertThat(logEntry.getText()).isEqualTo("Hello, world!");
-      assertThat(logEntry.getArgs().size()).isEqualTo(1);
+      assertThat(logEntry.getArgs()).hasSize(1);
       assertThat(logEntry.getArgs().get(0).getType()).isEqualTo("string");
       assertThat(logEntry.getType()).isEqualTo("console");
       assertThat(logEntry.getLevel()).isEqualTo(LogLevel.INFO);
@@ -78,7 +78,7 @@ void canFilterConsoleLogs() throws ExecutionException, InterruptedException, Tim
       ConsoleLogEntry logEntry = future.get(5, TimeUnit.SECONDS);
 
       assertThat(logEntry.getText()).isEqualTo("Hello, world!");
-      assertThat(logEntry.getArgs().size()).isEqualTo(1);
+      assertThat(logEntry.getArgs()).hasSize(1);
       assertThat(logEntry.getType()).isEqualTo("console");
       assertThat(logEntry.getLevel()).isEqualTo(LogLevel.INFO);
       assertThat(logEntry.getMethod()).isEqualTo("log");
@@ -91,12 +91,12 @@ void canFilterConsoleLogs() throws ExecutionException, InterruptedException, Tim
       ConsoleLogEntry errorLogEntry = errorLogFuture.get(5, TimeUnit.SECONDS);
 
       assertThat(errorLogEntry.getText()).isEqualTo("I am console error");
-      assertThat(errorLogEntry.getArgs().size()).isEqualTo(1);
+      assertThat(errorLogEntry.getArgs()).hasSize(1);
       assertThat(errorLogEntry.getType()).isEqualTo("console");
       assertThat(errorLogEntry.getLevel()).isEqualTo(LogLevel.ERROR);
       assertThat(errorLogEntry.getMethod()).isEqualTo("error");
       assertThat(errorLogEntry.getStackTrace()).isNotNull();
-      assertThat(errorLogEntry.getStackTrace().getCallFrames().size()).isEqualTo(2);
+      assertThat(errorLogEntry.getStackTrace().getCallFrames()).hasSize(2);
     }
   }
 
@@ -207,7 +207,7 @@ void canFilterLogs() throws ExecutionException, InterruptedException, TimeoutExc
 
       ConsoleLogEntry consoleLogEntry = logEntry.getConsoleLogEntry().get();
       assertThat(consoleLogEntry.getText()).isEqualTo("Hello, world!");
-      assertThat(consoleLogEntry.getArgs().size()).isEqualTo(1);
+      assertThat(consoleLogEntry.getArgs()).hasSize(1);
       assertThat(consoleLogEntry.getType()).isEqualTo("console");
       assertThat(consoleLogEntry.getLevel()).isEqualTo(LogLevel.INFO);
       assertThat(consoleLogEntry.getMethod()).isEqualTo("log");
@@ -232,7 +232,7 @@ void canListenToConsoleLogForABrowsingContext()
       ConsoleLogEntry logEntry = future.get(5, TimeUnit.SECONDS);
 
       assertThat(logEntry.getText()).isEqualTo("Hello, world!");
-      assertThat(logEntry.getArgs().size()).isEqualTo(1);
+      assertThat(logEntry.getArgs()).hasSize(1);
       assertThat(logEntry.getType()).isEqualTo("console");
       assertThat(logEntry.getLevel()).isEqualTo(LogLevel.INFO);
       assertThat(logEntry.getMethod()).isEqualTo("log");

java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java

@@ -117,7 +117,7 @@ void canListenToResponseCompletedEventWithCookie()
       BeforeRequestSent requestSent = future.get(5, TimeUnit.SECONDS);
       String windowHandle = driver.getWindowHandle();
       assertThat(requestSent.getBrowsingContextId()).isEqualTo(windowHandle);
-      assertThat(requestSent.getRequest().getCookies().size()).isEqualTo(1);
+      assertThat(requestSent.getRequest().getCookies()).hasSize(1);
       assertThat(requestSent.getRequest().getCookies().get(0).getName()).isEqualTo("foo");
       assertThat(requestSent.getRequest().getCookies().get(0).getValue().getValue())
           .isEqualTo("bar");

java/test/org/openqa/selenium/bidi/script/CallFunctionParameterTest.java

@@ -133,7 +133,7 @@ void canCallFunctionWithArguments() {
       EvaluateResultSuccess successResult = (EvaluateResultSuccess) result;
       assertThat(successResult.getResult().getType()).isEqualTo("array");
       assertThat(successResult.getResult().getValue().isPresent()).isTrue();
-      assertThat(((List<Object>) successResult.getResult().getValue().get()).size()).isEqualTo(2);
+      assertThat(((List<Object>) successResult.getResult().getValue().get())).hasSize(2);
     }
   }
 
@@ -339,8 +339,7 @@ void canCallFunctionThatThrowsException() {
       assertThat(exception.getExceptionDetails().getText()).contains("SyntaxError:");
       assertThat(exception.getExceptionDetails().getLineNumber()).isPositive();
       assertThat(exception.getExceptionDetails().getColumnNumber()).isPositive();
-      assertThat(exception.getExceptionDetails().getStacktrace().getCallFrames().size())
-          .isEqualTo(0);
+      assertThat(exception.getExceptionDetails().getStacktrace().getCallFrames()).hasSize(0);
     }
   }
 

java/test/org/openqa/selenium/bidi/script/EvaluateParametersTest.java

@@ -119,8 +119,7 @@ void canEvaluateScriptThatThrowsException() {
       assertThat(exception.getExceptionDetails().getException().getType()).isEqualTo("error");
       assertThat(exception.getExceptionDetails().getText()).contains("SyntaxError:");
       assertThat(exception.getExceptionDetails().getLineNumber()).isGreaterThanOrEqualTo(0);
-      assertThat(exception.getExceptionDetails().getStacktrace().getCallFrames().size())
-          .isEqualTo(0);
+      assertThat(exception.getExceptionDetails().getStacktrace().getCallFrames()).hasSize(0);
     }
   }