Skip to content

Commit 17108c9

Browse files
committed
Updated tests to use compiled cjs output instead of TS source
- Tests now import from `cjs/` instead of `src/` because Node.js cannot directly require TypeScript files. The build process compiles `.ts` source files to CommonJS `.js` files in `cjs/`, which is what tests need to execute. - The `pretest` script ensures `cjs/` is built before tests run, so tests always run against the latest compiled output.
1 parent 66c8637 commit 17108c9

38 files changed

+48
-48
lines changed

packages/url-utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"dev": "echo \"Implement me!\"",
1818
"pretest": "yarn build",
1919
"test": "NODE_ENV=testing c8 --all --reporter text --reporter cobertura --reporter html mocha './test/**/*.test.js'",
20-
"build": "rollup -c && tsc --declaration --emitDeclarationOnly --declarationDir ./types",
20+
"build": "rollup -c && tsc --declaration --emitDeclarationOnly --declarationDir ./types && tsc --module commonjs --outDir ./cjs/utils --rootDir ./src/utils --target es2016 --esModuleInterop true --skipLibCheck true src/utils/*.ts",
2121
"lint": "eslint . --ext .js --cache",
2222
"prepare": "NODE_ENV=production yarn build",
2323
"posttest": "yarn lint"

packages/url-utils/test/unit/url-utils.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ require('../utils');
44
const assert = require('assert/strict');
55

66
const sinon = require('sinon');
7-
const UrlUtils = require('../../src/UrlUtils');
7+
const UrlUtils = require('../../cjs/UrlUtils');
88
const configUrlHelpers = require('@tryghost/config-url-helpers');
99

1010
const constants = {

packages/url-utils/test/unit/utils/absolute-to-relative.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// const testUtils = require('./utils');
33
require('../../utils');
44

5-
const absoluteToRelative = require('../../../src/utils/absolute-to-relative');
5+
const absoluteToRelative = require('../../../cjs/utils/absolute-to-relative');
66

77
describe('utils: absoluteToRelative()', function () {
88
it('ignores relative URLs', function () {

packages/url-utils/test/unit/utils/absolute-to-transform-ready.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// const testUtils = require('./utils');
33
require('../../utils');
44

5-
const absoluteToTransformReady = require('../../../src/utils/absolute-to-transform-ready');
5+
const absoluteToTransformReady = require('../../../cjs/utils/absolute-to-transform-ready');
66

77
describe('utils: absoluteToTransformReady()', function () {
88
it('ignores relative URLs', function () {

packages/url-utils/test/unit/utils/deduplicate-double-slashes.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
require('../../utils');
22

3-
const deduplicateDoubleSlashes = require('../../../src/utils/deduplicate-double-slashes');
3+
const deduplicateDoubleSlashes = require('../../../cjs/utils/deduplicate-double-slashes');
44

55
describe('utils: deduplicateDoubleSlashes()', function () {
66
it('should deduplicate double slashes in URL', function () {

packages/url-utils/test/unit/utils/deduplicate-subdirectory.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// const testUtils = require('./utils');
33
require('../../utils');
44

5-
const deduplicateSubdirectory = require('../../../src/utils/deduplicate-subdirectory');
5+
const deduplicateSubdirectory = require('../../../cjs/utils/deduplicate-subdirectory');
66

77
describe('utils: deduplicateSubdirectory()', function () {
88
describe('with url', function () {

packages/url-utils/test/unit/utils/html-absolute-to-relative.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ require('../../utils');
55
const sinon = require('sinon');
66

77
const cheerio = require('cheerio');
8-
const htmlAbsoluteToRelative = require('../../../src/utils/html-absolute-to-relative');
8+
const htmlAbsoluteToRelative = require('../../../cjs/utils/html-absolute-to-relative');
99

1010
describe('utils: htmlAbsoluteToRelative()', function () {
1111
const siteUrl = 'http://my-ghost-blog.com';

packages/url-utils/test/unit/utils/html-absolute-to-transform-ready.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ const rewire = require('rewire');
66
const sinon = require('sinon');
77

88
const cheerio = require('cheerio');
9-
const htmlTransform = rewire('../../../src/utils/html-transform');
10-
const htmlAbsoluteToTransformReady = require('../../../src/utils/html-absolute-to-transform-ready');
9+
const htmlTransform = rewire('../../../cjs/utils/html-transform');
10+
const htmlAbsoluteToTransformReady = require('../../../cjs/utils/html-absolute-to-transform-ready');
1111

1212
describe('utils: htmlAbsoluteToTransformReady()', function () {
1313
const siteUrl = 'http://my-ghost-blog.com';

packages/url-utils/test/unit/utils/html-relative-to-absolute.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ const sinon = require('sinon');
66
const rewire = require('rewire');
77

88
const cheerio = require('cheerio');
9-
const htmlTransform = rewire('../../../src/utils/html-transform');
10-
const htmlRelativeToAbsolute = require('../../../src/utils/html-relative-to-absolute');
9+
const htmlTransform = rewire('../../../cjs/utils/html-transform');
10+
const htmlRelativeToAbsolute = require('../../../cjs/utils/html-relative-to-absolute');
1111

1212
describe('utils: htmlRelativeToAbsolute()', function () {
1313
const siteUrl = 'http://my-ghost-blog.com';

packages/url-utils/test/unit/utils/html-relative-to-transform-ready.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ require('../../utils');
55
const sinon = require('sinon');
66

77
const cheerio = require('cheerio');
8-
const htmlRelativeToTransformReady = require('../../../src/utils/html-relative-to-transform-ready');
8+
const htmlRelativeToTransformReady = require('../../../cjs/utils/html-relative-to-transform-ready');
99

1010
describe('utils: htmlRelativeToTransformReady()', function () {
1111
const siteUrl = 'http://my-ghost-blog.com';

0 commit comments

Comments
 (0)