fix: Block insert twice when using korean at suggestion (#1034)

d2n0s4ur · web-flow · commit 5700f90e2771 · 2024-08-28T22:04:56.000+02:00
* fix: add checking keydown isComposing for prevent create blocks when press enter.

* chore: move isCompoing to key check
diff --git a/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts b/packages/react/src/components/SuggestionMenu/GridSuggestionMenu/hooks/useGridSuggestionMenuKeyboardNavigation.ts
@@ -52,7 +52,7 @@ export function useGridSuggestionMenuKeyboardNavigation<Item>(
         return true;
       }
 
-      if (event.key === "Enter") {
+      if (event.key === "Enter" && !event.isComposing) {
         event.preventDefault();
 
         if (items.length) {
diff --git a/packages/react/src/components/SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts b/packages/react/src/components/SuggestionMenu/hooks/useSuggestionMenuKeyboardNavigation.ts
@@ -33,7 +33,7 @@ export function useSuggestionMenuKeyboardNavigation<Item>(
         return true;
       }
 
-      if (event.key === "Enter") {
+      if (event.key === "Enter" && !event.isComposing) {
         event.preventDefault();
 
         if (items.length) {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export function useGridSuggestionMenuKeyboardNavigation<Item>(`
`52`	`52`	`return true;`
`53`	`53`	`}`
`54`	`54`
`55`		`- if (event.key === "Enter") {`
	`55`	`+ if (event.key === "Enter" && !event.isComposing) {`
`56`	`56`	`event.preventDefault();`
`57`	`57`
`58`	`58`	`if (items.length) {`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ export function useSuggestionMenuKeyboardNavigation<Item>(`
`33`	`33`	`return true;`
`34`	`34`	`}`
`35`	`35`
`36`		`- if (event.key === "Enter") {`
	`36`	`+ if (event.key === "Enter" && !event.isComposing) {`
`37`	`37`	`event.preventDefault();`
`38`	`38`
`39`	`39`	`if (items.length) {`