Skip to content

Golden note effect draws outside of player UI when using four players and 'scrolling note stream' #558

@achimmihca

Description

@achimmihca

This bug is very visible when using scrolling note stream and more than 3 players.

Steps to reproduce

  • Set 'note display mode' to 'scrolling note stream'
  • Start a song with four player profiles
  • When there are golden notes, then the golden note effect does not respect the player UI area.

Expected Behavior

Golden notes of player A should not be drawn in the UI of player B.

Actual Behavior

The golden note effect is still visible in other player areas, scrolling through the whole screen.

Workaround

  • Use sentence-by-sentence display mode when playing with more than 3 players.

Implementation Hints

  • Reason is that the particle effect is above everything else, thus not respecting the player UI area.
  • One solution could be to create VisualElements inside the player UI area instead of using a particle system. But this has probably less optimal performance.
  • Another solution might be to do some trickery with the particle effect, something to restrict its drawing area. But not sure if this exists as needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions