Skip to content

Lock acquire/release requirement in BD configuration is too strict #2759

@jsetoain

Description

@jsetoain

In configureLocksInBdBlock @ lib/Targets/AIERT.cpp we force every block to have a lock-acquire and lock-release before and after the bd directive, but the BD allows for those two fields to be configured as "do not acquire/release a lock".

As it is, that assert forces us to acquire locks that are initialized as "open", and nobody is releasing; and likewise, release locks that nobody will every wait for. We should relax (or remove) that assertion and, when a release/acquire is missing, configure it as "do not release/acquire".

Metadata

Metadata

Assignees

No one assigned

    Labels

    invalidThis doesn't seem right

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions