@@ -102,10 +102,11 @@ def _level_for(value: int) -> str:
102102 return LEVELS [0 ][1 ]
103103
104104
105+ # pylint: disable=too-few-public-methods
105106class Handler :
106107 """Abstract logging message handler."""
107108
108- def __init__ (self , level = NOTSET ):
109+ def __init__ (self , level = NOTSET ): # pylint: disable=undefined-variable
109110 self .level = level
110111 """Level of the handler; this is currently unused, and
111112 only the level of the logger is used"""
@@ -128,6 +129,7 @@ def _emit(self, log_level: int, message: str):
128129 raise NotImplementedError ()
129130
130131
132+ # pylint: disable=too-few-public-methods
131133class StreamHandler (Handler ):
132134 """Send logging messages to a stream, `sys.stderr` (typically
133135 the serial console) by default.
@@ -136,7 +138,7 @@ class StreamHandler(Handler):
136138 """
137139
138140 def __init__ (self , stream = None ):
139- super .__init__ (self )
141+ super () .__init__ ()
140142 if stream is None :
141143 stream = sys .stderr
142144 self .stream = stream
@@ -232,7 +234,7 @@ def log(self, level: int, msg: str, *args):
232234
233235 """
234236 if level >= self ._level :
235- self ._handler ._emit (level , msg % args )
237+ self ._handler ._emit (level , msg % args ) # pylint: disable=protected-access
236238
237239 def debug (self , msg : str , * args ):
238240 """Log a debug message.
@@ -319,6 +321,9 @@ def error(self, format_string: str, *args):
319321 def critical (self , format_string : str , * args ):
320322 """Dummy implementation."""
321323
324+ def _emit (self , log_level : int , message : str ):
325+ """Dummy implementation"""
326+
322327
323328class FileHandler (StreamHandler ):
324329 """File handler for working with log files off of the microcontroller (like
@@ -329,13 +334,12 @@ class FileHandler(StreamHandler):
329334 """
330335
331336 def __init__ (self , filename : str , mode : str = "a" ) -> None :
332- self .logfile = open ( # pylint: disable=consider-using-with
333- filename , mode , encoding = "utf-8"
334- )
337+ # pylint: disable=consider-using-with
338+ super ().__init__ (open (filename , mode = mode ))
335339
336340 def close (self ):
337341 """Closes the file"""
338- self .logfile .close ()
342+ self .stream .close ()
339343
340344 def _format (self , log_level : int , message : str ):
341345 """Generate a string to log
@@ -351,4 +355,4 @@ def _emit(self, log_level: int, message: str):
351355 :param level: The level of the message
352356 :param msg: The message to log
353357 """
354- self .logfile .write (self ._format (log_level , message ))
358+ self .stream .write (self ._format (log_level , message ))
0 commit comments