Skip to content

Commit d7929f6

Browse files
authored
fix(interactive): fix memory leaks in complex data structures and support generic tuple (#4468)
Fixes
1 parent 5f02377 commit d7929f6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+2419
-2562
lines changed

flex/engines/graph_db/runtime/common/accessors.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ std::shared_ptr<IAccessor> create_context_value_accessor(const Context& ctx,
3737
return std::make_shared<ContextValueAccessor<Day>>(ctx, tag);
3838
case RTAnyType::kTimestamp:
3939
return std::make_shared<ContextValueAccessor<Date>>(ctx, tag);
40-
case RTAnyType::kStringSetValue:
41-
return std::make_shared<ContextValueAccessor<std::set<std::string>>>(ctx,
42-
tag);
4340
case RTAnyType::kBoolValue:
4441
return std::make_shared<ContextValueAccessor<bool>>(ctx, tag);
4542
case RTAnyType::kTuple:

flex/engines/graph_db/runtime/common/accessors.h

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,6 @@ class VertexPathAccessor : public IAccessor {
8585
return RTAny::from_vertex(typed_eval_path(idx));
8686
}
8787

88-
std::shared_ptr<IContextColumnBuilder> builder() const override {
89-
return vertex_col_.builder();
90-
}
91-
9288
private:
9389
const IVertexColumn& vertex_col_;
9490
};
@@ -110,10 +106,6 @@ class VertexGIdPathAccessor : public IAccessor {
110106
return RTAny::from_int64(typed_eval_path(idx));
111107
}
112108

113-
std::shared_ptr<IContextColumnBuilder> builder() const override {
114-
return vertex_col_.builder();
115-
}
116-
117109
private:
118110
const IVertexColumn& vertex_col_;
119111
};
@@ -238,10 +230,6 @@ class ContextValueAccessor : public IAccessor {
238230
return eval_path(idx);
239231
}
240232

241-
std::shared_ptr<IContextColumnBuilder> builder() const override {
242-
return col_.builder();
243-
}
244-
245233
private:
246234
const IValueColumn<elem_t>& col_;
247235
};
@@ -367,10 +355,6 @@ class EdgeIdPathAccessor : public IAccessor {
367355
return RTAny::from_edge(typed_eval_path(idx));
368356
}
369357

370-
std::shared_ptr<IContextColumnBuilder> builder() const override {
371-
return edge_col_.builder();
372-
}
373-
374358
private:
375359
const IEdgeColumn& edge_col_;
376360
};
@@ -404,10 +388,6 @@ class EdgePropertyPathAccessor : public IAccessor {
404388
return eval_path(idx);
405389
}
406390

407-
std::shared_ptr<IContextColumnBuilder> builder() const override {
408-
return col_.builder();
409-
}
410-
411391
private:
412392
const IEdgeColumn& col_;
413393
};
@@ -490,10 +470,6 @@ class MultiPropsEdgePropertyPathAccessor : public IAccessor {
490470
return eval_path(idx);
491471
}
492472

493-
std::shared_ptr<IContextColumnBuilder> builder() const override {
494-
return col_.builder();
495-
}
496-
497473
private:
498474
const IEdgeColumn& col_;
499475
std::vector<size_t> prop_index_;
@@ -517,10 +493,6 @@ class EdgeLabelPathAccessor : public IAccessor {
517493
return static_cast<int32_t>(e.label_triplet_.edge_label);
518494
}
519495

520-
std::shared_ptr<IContextColumnBuilder> builder() const override {
521-
return col_.builder();
522-
}
523-
524496
private:
525497
const IEdgeColumn& col_;
526498
};
@@ -665,10 +637,6 @@ class PathIdPathAccessor : public IAccessor {
665637

666638
RTAny eval_path(size_t idx) const override { return path_col_.get_elem(idx); }
667639

668-
std::shared_ptr<IContextColumnBuilder> builder() const override {
669-
return path_col_.builder();
670-
}
671-
672640
private:
673641
const IPathColumn& path_col_;
674642
};

0 commit comments

Comments
 (0)