Empty newText value for menu items in doCompletion

[fredericgiquel]

I noticed a weird behavior for modules completion in Emacs. If the documentation of the selected item is not shown, the completion result is deleted/empty.

I first tried to understand if the problem came from the Emacs side. By enabling trace mode of lsp-mode and examing the logs, I saw that :

• the textEdit.newText value is an empty string in textDocument/completion response (for all module items)
• the textEdit.newText value is <module_name>\n\n in completionItem/resolve response

According to https://microsoft.github.io/language-server-protocol/specification#textDocument_completion, textDocument/completion and completionItem/resolve must provided same values for all properties (except for detail and documentation).

So I wrote a quick workaround by copying code from doCompletionResolve function to doCompletion. You can see it here : fredericgiquel@20f19a0
It fixes the problem in Emacs.

I can open a PR if you want. But this is perhaps a better idea to do a refactoring in order to avoid replicating code between the 2 functions and to be sure there are no other similar problems. But I'm not able to do it.

PS. The problem can be reproduce in VSCodium:

• trigger an auto-completion for a module with "foreman" string
• choose "ansible.builtin.foreman" entry (no associated documentation)
  => the completion is empty