feat: assets support glob (#71)

Author: busyhe

package.json

@@ -58,7 +58,8 @@
     "convert-gitmoji": "^0.1.5",
     "execa": "^9.6.0",
     "ofetch": "^1.4.1",
-    "semver": "^7.7.2"
+    "semver": "^7.7.2",
+    "tinyglobby": "^0.2.14"
   },
   "devDependencies": {
     "@antfu/eslint-config": "^4.13.2",

pnpm-lock.yaml

@@ -27,7 +27,7 @@ cli
   .option('--emoji', 'Use emojis in section titles', { default: true })
   .option('--group', 'Nest commit messages under their scopes')
   .option('--dry', 'Dry run')
-  .option('--assets <paths...>', 'Files to upload as assets to the release')
+  .option('--assets <paths...>', 'Files to upload as assets to the release. Use quotes to prevent shell glob expansion, e.g., "--assets \'dist/*.js\'"')
   .help()
 
 async function readTokenFromGitHubCli() {

src/cli.ts

@@ -5,6 +5,7 @@ import path from 'node:path'
 import { notNullish } from '@antfu/utils'
 import { cyan, green, red } from 'ansis'
 import { $fetch } from 'ofetch'
+import { glob } from 'tinyglobby'
 
 export async function sendRelease(
   options: ChangelogOptions,
@@ -152,7 +153,6 @@ export async function hasTagOnGitHub(tag: string, options: ChangelogOptions) {
 
 export async function uploadAssets(options: ChangelogOptions, assets: string | string[]) {
   const headers = getHeaders(options)
-
   let assetList: string[] = []
   if (typeof assets === 'string') {
     assetList = assets.split(',').map(s => s.trim()).filter(Boolean)
@@ -163,32 +163,58 @@ export async function uploadAssets(options: ChangelogOptions, assets: string | s
     ).filter(Boolean)
   }
 
+  // Expand glob patterns to actual file paths
+  const expandedAssets: string[] = []
+  for (const pattern of assetList) {
+    try {
+      // Use the pattern directly without shell expansion
+      const matches = await glob(pattern)
+      if (matches.length) {
+        expandedAssets.push(...matches)
+      }
+      else {
+        // If no matches found, treat as literal path
+        expandedAssets.push(pattern)
+      }
+    }
+    catch (error) {
+      console.error(red(`Failed to process glob pattern "${pattern}": ${error}`))
+      // Keep the original pattern as fallback
+      expandedAssets.push(pattern)
+    }
+  }
+
   // Get the release by tag to obtain the upload_url
   const release = await $fetch(`https://${options.baseUrlApi}/repos/${options.releaseRepo}/releases/tags/${options.to}`, {
     headers,
   })
 
-  for (const asset of assetList) {
+  for (const asset of expandedAssets) {
     const filePath = path.resolve(asset)
-    const fileData = await fs.readFile(filePath)
-    const fileName = path.basename(filePath)
-    const contentType = 'application/octet-stream'
-
-    const uploadUrl = release.upload_url.replace('{?name,label}', `?name=${encodeURIComponent(fileName)}`)
-    console.log(cyan(`Uploading ${fileName}...`))
     try {
-      await $fetch(uploadUrl, {
-        method: 'POST',
-        headers: {
-          ...headers,
-          'Content-Type': contentType,
-        },
-        body: fileData,
-      })
-      console.log(green(`Uploaded ${fileName} successfully.`))
+      const fileData = await fs.readFile(filePath)
+      const fileName = path.basename(filePath)
+      const contentType = 'application/octet-stream'
+
+      const uploadUrl = release.upload_url.replace('{?name,label}', `?name=${encodeURIComponent(fileName)}`)
+      console.log(cyan(`Uploading ${fileName}...`))
+      try {
+        await $fetch(uploadUrl, {
+          method: 'POST',
+          headers: {
+            ...headers,
+            'Content-Type': contentType,
+          },
+          body: fileData,
+        })
+        console.log(green(`Uploaded ${fileName} successfully.`))
+      }
+      catch (error) {
+        console.error(red(`Failed to upload ${fileName}: ${error}`))
+      }
     }
     catch (error) {
-      console.error(red(`Failed to upload ${fileName}: ${error}`))
+      console.error(red(`Failed to read file ${filePath}: ${error}`))
     }
   }
 }