feat: Add dependency protocol checking and deletion checking for stream routing #12794
+375
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am routing Signed-off-by: Orician <[email protected]>
dosubot
bot
added
size:L
yixianOu
changed the title
5 tasks
…eanup. Fixed status code check in pingpong test to ensure correct error message is output when 400 error is returned 1. Update TEST 15 to expect 400 when creating a route with a non-existent superior_id, reflecting the new validation logic. 2. Add TEST 22 to clean up created stream routes after tests to prevent Etcd data pollution affecting subsequent tests (e.g., redis.t). Signed-off-by: Orician <[email protected]>
Author
|
Modified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements dependency protocol checking and deletion protection for stream routes, resolving #6939.
Previously, it was possible to create a subordinate stream route referencing a non-existent
superior_idor a superior route with a mismatched protocol. Additionally, superior routes could be deleted even while being referenced by subordinate routes, leading to potential runtime errors.Checklist
Changes
check_confto ensure that when asuperior_idis provided:delete_checkerto prevent the deletion of a stream route if it is currently referenced as asuperior_idby other routes.t/admin/stream-routes-subordinate.tcovering various scenarios including creation, protocol mismatch, and deletion protection.Related Issue
Resolves #6939
Sign-off
Signed-off-by: Orician [email protected]