Skip to content

Commit ecf520e

Browse files
committed
code review
1 parent 4eddd62 commit ecf520e

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/js/tabs/auxiliary.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function inBuildMap(map, name) {
5555
return true;
5656
}
5757
for (let value of map) {
58-
if (name == value.buildKey) {
58+
if (name.includes(value.buildKey)) {
5959
for (let option of value.buildOption) {
6060
if (FC.CONFIG.buildOptions.includes(option)) {
6161
return true;
@@ -79,23 +79,14 @@ function resolveCategoryName(category, choise) {
7979
let mList = [];
8080
for (let value of choise) {
8181
for (let elm of category) {
82-
if (value == elm.name) {
82+
if (value.includes(elm.name)) {
8383
mList.push(elm.modes);
8484
}
8585
}
8686
}
8787
return mList;
8888
}
8989

90-
function isPreSelectedCategory(categoryList, categoryName) {
91-
for (let value of categoryList) {
92-
if (value == categoryName) {
93-
return true;
94-
}
95-
}
96-
return false;
97-
}
98-
9990
function updateSearchResults() {
10091
let categorySelect = $('select.auxiliary_category_select');
10192

@@ -128,7 +119,7 @@ function createCategorySelect(table, map) {
128119
for (let value of table) {
129120
if (inBuildMap(map, value.buildKey) || FC.CONFIG.buildOptions.length == 0) {
130121
// selected build option or local build
131-
if (isPreSelectedCategory(categoryNameList, value.name)) {
122+
if (categoryNameList.includes(value.name)) {
132123
categorySelect.append(`<option value="${value.name}" selected="selected">${value.name}</option>`);
133124
}
134125
else {

0 commit comments

Comments
 (0)