Rework multiple spec and multiple targets for delayed modifier #3526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple nodes are targetted by one trigger specification, they share a delay. This is useful e.g. for active searches with multiple participating fields, so that the search triggers only when search modifiers have been processed. If a node has multiple triggers with the delay modifier, they act independently. This corresponds to the logic from bigskysoftware#2026.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If multiple nodes are targetted by one trigger specification, they share a delay. This is useful e.g. for active searches with multiple participating fields, so that the search triggers only when search modifiers have been processed.
If a node has multiple triggers with the delay modifier, they act independently. This corresponds to the logic from #2026.
Corresponding issue: #2892
This PR is the successor for #2893.
Testing
New tests have been added as appropriate.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded