Polish BSIP40 with latest change requests #2203
Conversation
See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r399386266
See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401052309 A compile error is now thrown if any operation field type is unsupported in use in any predicate with any argument type. See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r400286103 Unsigned_int is now supported as an integral type
See bitshares#2093 (comment) Add a cmake template file for the list_#.cpp files and autogenerate them from the template rather than having 12 almost identical copies of a file
See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r400317820
See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401581235 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401581502 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401582839 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401583091 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401588755
See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401599873
See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401604111 I can still get away with reordering the list like this because it's never been released yet.
Now allows ==, !=, <, <=, >, >= for stringish types (including hashes and vector<char>s), container size vs int, and static_variant.which() values vs int. vector<char> is no longer considered a container, but is considered stringish See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401604111 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401635775 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401642590
Add support for innteger comparisons against a stringish that is not a container, necessary because vector<char> is no longer a container but only stringish.
abitmore
modified the milestones:
6.0.0 - Protocol Upgrade Release,
7.0.0 - Protocol Upgrade Release
| /* 7 */ fc::sha256, \ | ||
| /* 8 */ fc::ripemd160, \ | ||
| /* 9 */ fc::hash160, \ | ||
| /* 10 */ account_id_type, \ |
There was a problem hiding this comment.
Unfortunately the reordering breaks the public testnet.
[54, {"fee"=>{"amount"=>300000, "asset_id"=>"1.3.0"}, "account"=>"1.2.24713", "enabled"=>true, "valid_from"=>"2019-11-15T00:00:00", "valid_to"=>"2019-11-30T00:00:00", "operation_type"=>0, "auth"=>{"weight_threshold"=>1, "account_auths"=>[["1.2.24713", 1]], "key_auths"=>[], "address_auths"=>[]}, "restrictions"=>[{"member_index"=>2, "restriction_type"=>0, "argument"=>[7, "1.2.23833"], "extensions"=>[]}], "extensions"=>[]}]
[55, {"fee"=>{"amount"=>230000, "asset_id"=>"1.3.0"}, "account"=>"1.2.24713", "authority_to_update"=>"1.17.0", "new_auth"=>{"weight_threshold"=>1, "account_auths"=>[["1.2.24714", 1]], "key_auths"=>[], "address_auths"=>[]}, "restrictions_to_remove"=>[], "restrictions_to_add"=>[], "extensions"=>[]}]
[54, {"fee"=>{"amount"=>330000, "asset_id"=>"1.3.0"}, "account"=>"1.2.24713", "enabled"=>true, "valid_from"=>"2019-11-15T00:00:00", "valid_to"=>"2019-11-30T00:00:00", "operation_type"=>1, "auth"=>{"weight_threshold"=>1, "account_auths"=>[["1.2.24713", 1]], "key_auths"=>[], "address_auths"=>[]}, "restrictions"=>[{"member_index"=>2, "restriction_type"=>10, "argument"=>[39, [{"member_index"=>1, "restriction_type"=>0, "argument"=>[8, "1.3.0"], "extensions"=>[]}]], "extensions"=>[]}], "extensions"=>[]}]
[55, {"fee"=>{"amount"=>230000, "asset_id"=>"1.3.0"}, "account"=>"1.2.24713", "authority_to_update"=>"1.17.1", "new_auth"=>{"weight_threshold"=>1, "account_auths"=>[["1.2.24714", 1]], "key_auths"=>[], "address_auths"=>[]}, "restrictions_to_remove"=>[], "restrictions_to_add"=>[], "extensions"=>[]}]
There was a problem hiding this comment.
Ahh? I didn't realize this had been released, much less used. The fix is just to move the new hash types to the bottom of the list, no?
abitmore
modified the milestones:
7.0.0 - Protocol Upgrade Release,
8.0.0 - Protocol Upgrade Release
2 participants
This addresses abit's change requests wrt BSIP40 in #2093