Skip to content

Commit 09914d6

Browse files
authored
fix: inclusive naming check (#382)
1 parent 21c54dc commit 09914d6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ juju deploy ./alertmanager-k8s.charm \
151151
service restart, to minimize downtime.
152152

153153

154-
[Alertmanager API browser]: https://petstore.swagger.io/?url=https://raw.githubusercontent.com/prometheus/alertmanager/master/api/v2/openapi.yaml
154+
[Alertmanager API browser]: https://petstore.swagger.io/?url=https://raw.githubusercontent.com/prometheus/alertmanager/main/api/v2/openapi.yaml
155155
[gh:Prometheus operator]: https://github.com/canonical/prometheus-operator
156156
[Prometheus operator]: https://charmhub.io/prometheus-k8s
157157
[COS Lite]: https://charmhub.io/cos-lite

lib/charms/alertmanager_k8s/v0/alertmanager_remote_configuration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Increment this PATCH version before using `charmcraft publish-lib` or reset
4040
# to 0 if you are raising the major API version
41-
LIBPATCH = 3
41+
LIBPATCH = 4
4242

4343
logger = logging.getLogger(__name__)
4444

@@ -57,7 +57,7 @@ def __init__(self, config_file: str):
5757
def config_main_keys_are_valid(config: Optional[dict]) -> bool:
5858
"""Checks whether main keys in the Alertmanager's config file are valid.
5959
60-
This method facilitates the basic sanity check of Alertmanager's configuration. It checks
60+
This method facilitates the basic confidence check of Alertmanager's configuration. It checks
6161
whether given configuration contains only allowed main keys or not. `templates` have been
6262
removed from the list of allowed main keys to reflect the fact that `alertmanager-k8s` doesn't
6363
accept it as part of config (see `alertmanager-k8s` description for more details).
@@ -408,7 +408,7 @@ def load_config_file(path: str) -> dict:
408408
def update_relation_data_bag(self, alertmanager_config: Optional[dict]) -> None:
409409
"""Updates relation data bag with Alertmanager config and templates.
410410
411-
Before updating relation data bag, basic sanity check of given configuration is done.
411+
Before updating relation data bag, basic confidence check of given configuration is done.
412412
413413
Args:
414414
alertmanager_config: Alertmanager configuration dictionary.

0 commit comments

Comments
 (0)