Skip to content

Conversation

@M-SaaD-H
Copy link

@M-SaaD-H M-SaaD-H commented Dec 3, 2025

Issue #18064

Added ArrayBracketNoWhitespace check with respective tests and input files.

@romani
Copy link
Member

romani commented Dec 5, 2025

Please read and watch videos at Starting_Development.
Please make CI green.

@M-SaaD-H
Copy link
Author

M-SaaD-H commented Dec 5, 2025

Hi @romani ,
I have tested the check locally before raising the PR, but overlooked the XpathRegression tests. I am sorry for this, but I am facing some issues in passing these tests. I have asked this in the discord channel but didn't got the solution from there too. It will be really helpful if you could help me in understanding and solving this issue.
Tagged you in the related thread on discord.

@romani
Copy link
Member

romani commented Dec 5, 2025

Just debug test and trace all lines to understand why there is no violation. All is debug-able.

@SURYANSHUAGRAWAL2006
Copy link

SURYANSHUAGRAWAL2006 commented Dec 5, 2025

@saad please make sure commit should be only one so, please squash all commits into single one.

@mohitsatr
Copy link
Member

@M-SaaD-H please push the changes so we can see what's wrong with XpathRegression tests. It's little hard to understand from images.

@M-SaaD-H
Copy link
Author

M-SaaD-H commented Dec 7, 2025

@mohitsatr I have pushed the code.
Please look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants