scaffolds maintainer-d API and workspaces for kcp #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Kielty <[email protected]>
- adopts structural CRDs for maintainer-d APIs via controller-gen and
reference types
- generate concrete APIResourceSchemas/APIExport with apigen and hook
them into Make target
- rename the API group to maintainer-d.cncf.io, updating manifests,
docs and helper scripts accordingly
New/Updated Makefile targets
- make kcp-install
downloads/verifies the matching kcp release tools (kcp, apigen) into ./bin/
Run it once per dev environment—or again when you bump KCP_VERSION.
- make kcp-generate
new workflow hook: it runs controller-gen against apis/... to refresh the CRDs
in config/crd/bases/, then pipes those through apigen to rewrite every
APIResourceSchema plus the APIExport under config/kcp/.
Run it whenever you change Go types, resource annotations, or switch API
group/version so the manifests stay in sync before committing or applying
to kcp.
Signed-off-by: Robert Kielty <[email protected]>
embik
reviewed
Oct 22, 2025
apis/maintainers/v1alpha1/types.go
Outdated
| // +kubebuilder:object:root=true | ||
|
|
||
| // AuditLog is an append-only record for significant maintainer operations. | ||
| type AuditLog struct { |
Collaborator
There was a problem hiding this comment.
I don't think this should be in a resource, kcp supports Kubernetes' audit logging capabilities. If we need this data, we should probably craft an audit policy that captures the relevant data in kcp.
apis/maintainers/v1alpha1/types.go
Outdated
| // +kubebuilder:subresource:status | ||
|
|
||
| // ReconciliationResult stores reconciliation findings for audit and follow-up. | ||
| type ReconciliationResult struct { |
Collaborator
There was a problem hiding this comment.
Similar note here, I don't think I would store results like this to not overload etcd. It would probably make more sense to store any problems in conditions on the respective object's status subresource.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the review feedback! Much appreciated, I'll remove those resources from the workspace.
- drops the AuditLog and ReconciliationResult types, regenerates deep copies - deletes the CRDs and APIResourceSchemas for the removed resources - updates the KCP export, schema version names and Makefile resource list Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
ran go download and go mod tidy to attempt to sort or dependancy issues Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-pass implementation #22 that sets up new CRDs, schema exports, binding manifests and some Makefile targets and docs for kcp.