Answer: Adapt to use CONFIG_TEMPLATE

Replace the use of environment variables with
config variable

Closes #381

Author: nvzard

config.py

@@ -113,6 +113,9 @@
 AUTOINSTALL_DEPS = True
 
 DEFAULT_CONFIG = {
+    'answer': {
+        'ANSWER_END': os.environ.get('ANSWER_END'),
+    },
     'LabHub': {
         'GH_TOKEN': os.environ.get('GH_TOKEN'),
         'GL_TOKEN': os.environ.get('GL_TOKEN'),

plugins/answer.py

@@ -1,13 +1,16 @@
 import json
-import os
 from urllib.parse import quote_plus, urljoin
 
 from errbot import BotPlugin, botcmd
+from utils.mixin import DefaultConfigMixin
 import requests
 
 
-class Answer(BotPlugin):
+class Answer(DefaultConfigMixin, BotPlugin):
 
+    CONFIG_TEMPLATE = {
+        'ANSWER_END': None,
+    }
     # Ignore LineLengthBear, PyCodestyleBear
     SURVEY_LINK = 'https://docs.google.com/forms/d/e/1FAIpQLSeD8lqMWAwJx0Mewlpc5Sbeo3MH5Yi9fSfXA6jnk07-aIURSA/viewform?usp=pp_url&entry.1236347280={question}&entry.1734934116={response}&entry.75323266={message_link}'
     MESSAGE_LINK = 'https://gitter.im/{uri}?at={idd}'
@@ -26,7 +29,7 @@ def construct_link(text):
     @botcmd
     def answer(self, msg, arg):
         try:
-            answers = requests.get(urljoin(os.environ['ANSWER_END'], 'answer'),
+            answers = requests.get(urljoin(self.config['ANSWER_END'], 'answer'),
                                    params={'question': arg}).json()
         except json.JSONDecodeError:
             self.log.exception('something went wrong while fetching answer for'

tests/answer_test.py

@@ -1,4 +1,3 @@
-import os
 import vcr
 import requests_mock
 
@@ -9,13 +8,16 @@
 class TestAnswer(IsolatedTestCase):
 
     def setUp(self):
-        super().setUp()
         # Ignore InvalidLinkBear
         self.answer_end_point = 'http://0.0.0.0:8000'
-        os.environ['ANSWER_END'] = self.answer_end_point
-
-    def tearDown(self):
-        del os.environ['ANSWER_END']
+        extra_config = {
+            'DEFAULT_CONFIG': {
+                'answer': {
+                    'ANSWER_END': self.answer_end_point,
+                }
+            }
+        }
+        super().setUp(extra_config=extra_config)
 
     @vcr.use_cassette('tests/cassettes/answer.yaml')
     def test_answer(self):
@@ -24,6 +26,8 @@ def test_answer(self):
         self.assertIn('Please checkout the following links', self.pop_message())
         self.push_message('!answer shell autocompletion')
         self.assertIn('Please checkout the following links', self.pop_message())
+        self.assertCommand('!plugin config answer',
+                           str({'ANSWER_END': self.answer_end_point}))
 
     def test_invalid_json(self):
         with requests_mock.Mocker() as m: