fix: helmet.cpp: documentation and move constructor fixes.

Signed-off-by: Amlal El Mahrouss <[email protected]>

Author: amlel-el-mahrouss

include/boost/http_proto/server/helmet.hpp

@@ -232,7 +232,7 @@ using option_pair = std::pair<std::string, std::vector<std::string>>;
     opts.set(x_frame_origin(helmet_origin_type::deny));
 
     helmet::csp_policy csp;
-    csp.set("script-src", csp_type::self);
+    csp.allow("script-src", csp_type::self);
     opts.set(content_security_policy(csp));
 
     srv.wwwroot.use(helmet(opts));
@@ -268,9 +268,9 @@ class helmet
         @par Example
         @code
         helmet::csp_policy policy;
-        policy.set("script-src", csp_type::self)
-              .set("style-src", "https://example.com")
-              .set("img-src", csp_type::none);
+        policy.allow("script-src", csp_type::self)
+              .allow("style-src", "https://example.com")
+              .allow("img-src", csp_type::none);
         @endcode
     */
     struct csp_policy
@@ -284,7 +284,7 @@ class helmet
         BOOST_HTTP_PROTO_DECL
         ~csp_policy();
 
-        /** Append a CSP directive with a predefined type.
+        /** Allows a CSP directive with a predefined type.
 
             @param allow The directive name (e.g., "script-src").
             @param type The CSP source expression type.

src/server/helmet.cpp

@@ -113,9 +113,8 @@ helmet& helmet::operator=(helmet&& other) noexcept
 
 helmet::
 helmet(helmet&& other) noexcept
+    : impl_(other.impl_)
 {
-    delete impl_;
-    impl_ = other.impl_;
     other.impl_ = nullptr;
 }
 
@@ -156,7 +155,8 @@ helmet::csp_policy& helmet::csp_policy::allow(const core::string_view& allow,
     value += source.data();
 
 	auto it = std::find_if(list.begin(), list.end(), [&allow](const std::string& in) {
-        return in.find(allow) != std::string::npos;
+        std::string allow_with_space = std::string(allow) + " ";
+        return in.find(allow_with_space) != std::string::npos;
     });
 
     if (it == list.end())
@@ -224,7 +224,8 @@ helmet::csp_policy& helmet::csp_policy::allow(const core::string_view& allow, co
     }
 
 	auto it = std::find_if(list.begin(), list.end(), [&allow](const std::string& in) {
-        return in.find(allow) != std::string::npos;
+        std::string allow_with_space = std::string(allow) + " ";
+        return in.find(allow_with_space) != std::string::npos;
     });
 
     if (it == list.end())
@@ -250,7 +251,8 @@ helmet::csp_policy::~csp_policy() = default;
 helmet::csp_policy& helmet::csp_policy::remove(const core::string_view& allow)
 {
     if (auto it = std::find_if(list.cbegin(), list.cend(), [&allow](const std::string& in) {
-        return in.find(allow) != std::string::npos;
+        std::string allow_with_space = std::string(allow) + " ";
+        return in.find(allow_with_space) != std::string::npos;
     }); it != list.cend())
     {
         list.erase(it);