Adasp 33 oauth #11
Open
Adasp 33 oauth #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library on page load, plus get signedin or not
… in and signs out user
…ding state of whether or not it is open to rtk.
Codecov Report
@@ Coverage Diff @@
## develop #11 +/- ##
============================================
- Coverage 100.00% 81.43% -18.57%
============================================
Files 12 19 +7
Lines 79 167 +88
Branches 15 31 +16
============================================
+ Hits 79 136 +57
- Misses 0 31 +31
Continue to review full report at Codecov.
|
… is set to open after reducer is called
… same as if true, due to tests
amtadros
reviewed
Jun 9, 2021
amtadros
left a comment
amtadros
left a comment
There was a problem hiding this comment.
Nice work! Just left a few questions.
…ion. also adding google login dependency
…e login component to drawer
…dding styles to drawer to make absolute and therefore not move the main task page around
… to see if token exists, and if so, dispatch and sign in
…the name in the header after signing in.
Contributor
|
@RubySpeeders how can we be of help here? 😄 |
roblafeve
reviewed
Jul 23, 2021
Comment on lines
+10
to
+12
| client_id: Cypress.env("googleClientId"), | ||
| client_secret: Cypress.env("googleClientSecret"), | ||
| refresh_token: Cypress.env("googleRefreshToken"), |
Contributor
There was a problem hiding this comment.
@RubySpeeders I think that we need to add these variables to the GitHub repo settings in order to successfully authenticate. This would be the information you have in your .env file I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DESCRIPTION_HERE
🔗 Reference
📋 Acceptance Criteria
👩🔬 Test Instructions
🔎 Reviewer Checklist