Prevent dropdown from disappearing when mouse downed on scrollbar. (Tested in IE8.)

Guy Lister · Guy Lister · commit 2ad28201de23 · 2014-02-07T17:42:30.000-05:00
diff --git a/js/bootstrap-combobox.js b/js/bootstrap-combobox.js
@@ -122,12 +122,16 @@
         })
         .show();
 
+      $('.dropdown-menu').on('mousedown', $.proxy(this.scrollSafety, this));
+
       this.shown = true;
       return this;
     }
 
   , hide: function () {
       this.$menu.hide();
+      $('.dropdown-menu').off('mousedown', $.proxy(this.scrollSafety, this));
+      this.$element.on('blur', $.proxy(this.blur, this));
       this.shown = false;
       return this;
     }
@@ -230,6 +234,11 @@
     }
   }
 
+  , scrollSafety: function(e) {
+      if (e.target.tagName == 'UL') {
+          this.$element.off('blur');
+      }
+  }
   , clearElement: function () {
     this.$element.val('').focus();
   }

Original file line number	Diff line number	Diff line change
`@@ -122,12 +122,16 @@`
`122`	`122`	`})`
`123`	`123`	`.show();`
`124`	`124`
	`125`	`+ $('.dropdown-menu').on('mousedown', $.proxy(this.scrollSafety, this));`
	`126`	`+`
`125`	`127`	`this.shown = true;`
`126`	`128`	`return this;`
`127`	`129`	`}`
`128`	`130`
`129`	`131`	`, hide: function () {`
`130`	`132`	`this.$menu.hide();`
	`133`	`+ $('.dropdown-menu').off('mousedown', $.proxy(this.scrollSafety, this));`
	`134`	`+ this.$element.on('blur', $.proxy(this.blur, this));`
`131`	`135`	`this.shown = false;`
`132`	`136`	`return this;`
`133`	`137`	`}`
`@@ -230,6 +234,11 @@`
`230`	`234`	`}`
`231`	`235`	`}`
`232`	`236`
	`237`	`+ , scrollSafety: function(e) {`
	`238`	`+ if (e.target.tagName == 'UL') {`
	`239`	`+ this.$element.off('blur');`
	`240`	`+ }`
	`241`	`+ }`
`233`	`242`	`, clearElement: function () {`
`234`	`243`	`this.$element.val('').focus();`
`235`	`244`	`}`