Merge pull request #499 from shiftkey/release-notes-fixes

Fixes for release notes script

Author: tidy-dev

.github/workflows/ci.yml

@@ -141,6 +141,8 @@ jobs:
     needs: [build, shellcheck]
     if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
     steps:
       - uses: actions/checkout@v2
 

script/generate-release-notes.ts

@@ -4,10 +4,10 @@ import * as fs from 'fs'
 import { Octokit } from '@octokit/rest'
 
 export default class GenerateReleaseNotes {
-  // five targeted OS/arch combinations
+  // Eight targeted OS/arch combinations
   // two files for each targeted OS/arch
   // two checksum files for the previous
-  private SUCCESSFUL_RELEASE_FILE_COUNT = 5 * 2 * 2
+  private SUCCESSFUL_RELEASE_FILE_COUNT = 8 * 2 * 2
   private args = process.argv.slice(2)
   private expectedArgs = [
     {
@@ -163,7 +163,7 @@ export default class GenerateReleaseNotes {
       const match = mergeCommitRegex.exec(mergeCommitMessage)
       if (match != null && match.length === 2) {
         const num = parseInt(match[1])
-        if (num != NaN) {
+        if (!Number.isNaN(num)) {
           pullRequestIds.push(num)
         }
       }