Skip to content

Commit 9e42dc0

Browse files
committed
review: Address review feedback
- Add nil checks for Snapshot - Change format string for supported output formats
1 parent aeb5e79 commit 9e42dc0

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

cmd/docker-mcp/commands/workingset.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ Filters use key=value format (e.g., name=github, profile=my-dev-env).`,
344344

345345
flags := cmd.Flags()
346346
flags.StringArrayVarP(&opts.Filters, "filter", "f", []string{}, "Filter output (e.g., name=github, profile=my-dev-env)")
347-
flags.StringVar(&opts.Format, "format", string(workingset.OutputFormatHumanReadable), fmt.Sprintf("Output format (%s)", strings.Join(workingset.SupportedFormats(), "|")))
347+
flags.StringVar(&opts.Format, "format", string(workingset.OutputFormatHumanReadable), fmt.Sprintf("Supported: %s.", strings.Join(workingset.SupportedFormats(), ", ")))
348348

349349
return cmd
350350
}

pkg/workingset/server.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ func RemoveServers(ctx context.Context, dao db.DAO, id string, serverNames []str
122122
originalCount := len(workingSet.Servers)
123123
filtered := make([]Server, 0, len(workingSet.Servers))
124124
for _, server := range workingSet.Servers {
125-
if !namesToRemove[server.Snapshot.Server.Name] {
125+
// TODO: Remove when Snapshot is required
126+
if server.Snapshot == nil || !namesToRemove[server.Snapshot.Server.Name] {
126127
filtered = append(filtered, server)
127128
}
128129
}
@@ -247,6 +248,10 @@ func buildSearchResults(dbSets []db.WorkingSet, nameFilter string) []SearchResul
247248
}
248249

249250
func matchesNameFilter(server Server, nameLower string) bool {
251+
// TODO: Remove when Snapshot is required
252+
if server.Snapshot == nil {
253+
return false
254+
}
250255
if nameLower == "" {
251256
return true
252257
}

0 commit comments

Comments
 (0)