Skip to content

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Dec 3, 2025

This pull request updates naming and descriptions for Aspire starter templates to improve clarity and consistency, especially around technology stacks used in each template. It also removes an obsolete project file and refines metadata for the Python/React starter template.

It is easier to review commit-by-commit, since the first commit is just a simple folder rename.

Template Naming and Description Updates:

  • Renamed the description for AspireStarter_Description to "Starter App (ASP.NET Core/Blazor)" for clearer tech stack identification.
  • Updated the description for AspireJsFrontendStarter_Description to "Starter App (ASP.NET Core/React)" to better reflect its components.
  • Changed the description for AspirePyStarter_Description to "Starter App (FastAPI/React)" for accuracy.

Template ID and Metadata Changes:

  • Changed the internal template ID from "aspire-js-frontend-starter" to "aspire-starter-ts-cs" in DotNetTemplateFactory.cs to align with new naming conventions.
  • Updated template.json for the Python starter: added new tags ("TypeScript", "React"), changed language to "Python", and revised identity/groupIdentity fields for consistency with the new naming scheme. Also improved the description to mention optional Redis caching.

esproj

  • Always generate an esproj, even from the command line.

@eerhardt eerhardt requested review from DamianEdwards and Copilot and removed request for Copilot December 3, 2025 23:27
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13319

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13319"

Copilot AI review requested due to automatic review settings December 3, 2025 23:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates Aspire starter templates to improve naming consistency and clarity across the template ecosystem. The changes rename template descriptions to explicitly identify technology stacks (ASP.NET Core/Blazor, ASP.NET Core/React, FastAPI/React), update internal template IDs to follow new naming conventions, and ensure the esproj file is always generated regardless of the host environment.

Key Changes:

  • Renamed template descriptions to include explicit technology stack identifiers
  • Changed template ID from "aspire-js-frontend-starter" to "aspire-starter-ts-cs" for the React/TypeScript template
  • Updated identity and groupIdentity fields for consistency
  • Added new TypeScript/React template files with modern Vite/React setup
  • Removed conditional exclusion of esproj files

Reviewed changes

Copilot reviewed 23 out of 69 changed files in this pull request and generated no comments.

Show a summary per file
File Description
aspire-starter/.template.config/template.json Updated name and description to "Aspire Starter App (ASP.NET Core/Blazor)" for clarity
aspire-starter/.template.config/localize/templatestrings.en.json Updated English localization strings to match new naming
aspire-starter-ts-cs/.template.config/template.json Changed shortName from "aspire-js-frontend-starter" to "aspire-starter-ts-cs", updated identity/groupIdentity, changed "JavaScript" to "TypeScript" in classifications, removed conditional esproj exclusion
aspire-starter-ts-cs/.template.config/localize/*.json Added new localization files for Chinese, Turkish, and Russian languages
aspire-starter-ts-cs/frontend/* Added complete React/TypeScript/Vite frontend template files including configuration and source code
aspire-starter-ts-cs/Aspire-StarterApplication.1.Server/* Added ASP.NET Core backend server files with minimal API and service defaults
aspire-starter-ts-cs/Aspire-StarterApplication.1.AppHost/* Added AppHost project files for distributed application orchestration
aspire-starter-ts-cs/Aspire-StarterApplication.1.sln Added solution file with conditional esproj inclusion for Visual Studio

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future PRs, we should also add some tests to at least create+build all the templates we have.

@eerhardt
Copy link
Member Author

eerhardt commented Dec 8, 2025

image

is the new list

@davidfowl
Copy link
Member

I hate it but let's merge it (disagree and commit)

@eerhardt eerhardt merged commit 2bf8e84 into dotnet:main Dec 8, 2025
286 checks passed
@eerhardt eerhardt deleted the FixUpTemplateMore branch December 8, 2025 21:09
@eerhardt
Copy link
Member Author

eerhardt commented Dec 8, 2025

I hate it but let's merge it (disagree and commit)

What do you hate about it?

@dotnet-policy-service dotnet-policy-service bot added this to the 13.1 milestone Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants