-
Notifications
You must be signed in to change notification settings - Fork 749
Make Aspire templates consistent #13319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13319Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13319" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates Aspire starter templates to improve naming consistency and clarity across the template ecosystem. The changes rename template descriptions to explicitly identify technology stacks (ASP.NET Core/Blazor, ASP.NET Core/React, FastAPI/React), update internal template IDs to follow new naming conventions, and ensure the esproj file is always generated regardless of the host environment.
Key Changes:
- Renamed template descriptions to include explicit technology stack identifiers
- Changed template ID from "aspire-js-frontend-starter" to "aspire-starter-ts-cs" for the React/TypeScript template
- Updated identity and groupIdentity fields for consistency
- Added new TypeScript/React template files with modern Vite/React setup
- Removed conditional exclusion of esproj files
Reviewed changes
Copilot reviewed 23 out of 69 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| aspire-starter/.template.config/template.json | Updated name and description to "Aspire Starter App (ASP.NET Core/Blazor)" for clarity |
| aspire-starter/.template.config/localize/templatestrings.en.json | Updated English localization strings to match new naming |
| aspire-starter-ts-cs/.template.config/template.json | Changed shortName from "aspire-js-frontend-starter" to "aspire-starter-ts-cs", updated identity/groupIdentity, changed "JavaScript" to "TypeScript" in classifications, removed conditional esproj exclusion |
| aspire-starter-ts-cs/.template.config/localize/*.json | Added new localization files for Chinese, Turkish, and Russian languages |
| aspire-starter-ts-cs/frontend/* | Added complete React/TypeScript/Vite frontend template files including configuration and source code |
| aspire-starter-ts-cs/Aspire-StarterApplication.1.Server/* | Added ASP.NET Core backend server files with minimal API and service defaults |
| aspire-starter-ts-cs/Aspire-StarterApplication.1.AppHost/* | Added AppHost project files for distributed application orchestration |
| aspire-starter-ts-cs/Aspire-StarterApplication.1.sln | Added solution file with conditional esproj inclusion for Visual Studio |
radical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future PRs, we should also add some tests to at least create+build all the templates we have.
src/Aspire.ProjectTemplates/templates/aspire-starter-ts-cs/frontend/frontend.esproj
Outdated
Show resolved
Hide resolved
|
I hate it but let's merge it (disagree and commit) |
What do you hate about it? |

This pull request updates naming and descriptions for Aspire starter templates to improve clarity and consistency, especially around technology stacks used in each template. It also removes an obsolete project file and refines metadata for the Python/React starter template.
It is easier to review commit-by-commit, since the first commit is just a simple folder rename.
Template Naming and Description Updates:
AspireStarter_Descriptionto "Starter App (ASP.NET Core/Blazor)" for clearer tech stack identification.AspireJsFrontendStarter_Descriptionto "Starter App (ASP.NET Core/React)" to better reflect its components.AspirePyStarter_Descriptionto "Starter App (FastAPI/React)" for accuracy.Template ID and Metadata Changes:
"aspire-js-frontend-starter"to"aspire-starter-ts-cs"inDotNetTemplateFactory.csto align with new naming conventions.template.jsonfor the Python starter: added new tags ("TypeScript", "React"), changed language to "Python", and revised identity/groupIdentity fields for consistency with the new naming scheme. Also improved the description to mention optional Redis caching.esproj