From 40e6faa3e60a1f3f75a2d30417d747d1d0dc8b89 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 20:17:40 +0000 Subject: [PATCH 1/3] Initial plan From 3e840608703fcb95ebbc27c810b4dca4cb881b7b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 20:24:38 +0000 Subject: [PATCH 2/3] Update results job to check skip_workflow on all declared dependencies Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com> --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2583d2e269a..bdbae87b09f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -86,6 +86,7 @@ jobs: steps: - name: Fail if any of the dependent jobs failed # Don't fail if the workflow is being skipped. + # Check skip_workflow on all declared dependencies. # # For others 'skipped' can be when a transitive dependency fails and the dependent job gets # 'skipped'. For example, one of setup_* jobs failing and the Integration test jobs getting @@ -93,6 +94,8 @@ jobs: if: >- ${{ always() && needs.prepare_for_ci.outputs.skip_workflow != 'true' && + needs.tests.outputs.skip_workflow != 'true' && + needs.build_cli_archives.outputs.skip_workflow != 'true' && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped')) }} From 52d792e5e996b1e8da2e2973a06bb93cd5e1d229 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 5 Dec 2025 20:26:04 +0000 Subject: [PATCH 3/3] Add comment explaining skip_workflow check behavior for all dependencies Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com> --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bdbae87b09f..d49856a8246 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -86,7 +86,9 @@ jobs: steps: - name: Fail if any of the dependent jobs failed # Don't fail if the workflow is being skipped. - # Check skip_workflow on all declared dependencies. + # Check skip_workflow on all declared dependencies. Workflows without + # skip_workflow outputs (e.g., tests, build_cli_archives) evaluate to + # empty string, so the check still works ('!= true' is true for empty). # # For others 'skipped' can be when a transitive dependency fails and the dependent job gets # 'skipped'. For example, one of setup_* jobs failing and the Integration test jobs getting