[XSG][BindingSourceGen] Add support for CommunityToolkit.Mvvm ObservablePropertyAttribute #33028
+414
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Binding source generators now support properties generated by CommunityToolkit.Mvvm's
[ObservableProperty]attribute. Previously, bindings failed because MAUI generators cannot see properties generated by other source generators.Implementation (following PR #32954 pattern for RelayCommand):
BindingSourceGen/ITypeSymbolExtensions.cs: Added
TryGetObservablePropertyType()to detect fields with[ObservableProperty]and infer property types. Supports bothcamelCaseand_camelCasefield naming patterns.BindingSourceGen/PathParser.cs: Enhanced
TryHandleSpecialCases()to handle ObservableProperty patterns as fallback when symbol resolution fails.BindingSourceGen/BindingSourceGenerator.cs: Updated
GetLambdaReturnType()to infer types from ObservableProperty fields, enabling C# lambda bindings.SourceGen/ITypeSymbolExtensions.cs: Updated
TryGetProperty()to check ObservableProperty-inferred properties, enabling XAML string-based bindings.Works for both XAML and C# bindings:
Issues Fixed
Fixes #32597
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.