Skip to content

Commit f2da7d4

Browse files
committed
t0600: fix incomplete prerequisite for a test case
The 'symref transaction supports symlinks' test case is guarded by the `SYMLINK` prerequisite because `core.prefersymlinkrefs = true` requires symbolic links to be supported. However, the `preferSymlinkRefs` feature is not supported on Windows, therefore this test case needs the `MINGW` prerequisite, too. There's a couple more cases where we set this config key: - In a subsequent test in t0600, but there we explicitly set it to "false". So this would naturally be supported by Windows. - In t7201 we set the value to `yes`, but we never verify that the written reference is a symbolic link in the first place. I guess that we could rather remove setting the configuration value here, as we are about to deprecate support for symrefs via symbolic links in the first place. But that's certainly outside of the scope of this patch. - In t9903 we do the same, but likewise, we don't check whether the written file is a symbolic link. Therefore this seems to be the only instance where the tests actually need to be adapted. Helped-by: Patrick Steinhardt <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 3db0599 commit f2da7d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t0600-reffiles-backend.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' '
467467
esac
468468
'
469469

470-
test_expect_success SYMLINKS 'symref transaction supports symlinks' '
470+
test_expect_success SYMLINKS,!MINGW 'symref transaction supports symlinks' '
471471
test_when_finished "git symbolic-ref -d TEST_SYMREF_HEAD" &&
472472
git update-ref refs/heads/new @ &&
473473
test_config core.prefersymlinkrefs true &&

0 commit comments

Comments
 (0)