Skip to content

Conversation

@dvansari65
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
I wrapped app name and app path in double quote, this avoids macOS treating spaces as argument separators during

@dvansari65 dvansari65 requested a review from a team as a code owner November 26, 2025 03:20
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you dive into where this is happening inside electron-installer-dmg? I traced the code just now and it looks like everything is using args not string concatenation so spaces shouldn't matter.

We also build an app internally called Foo Bar.app which correctly builds as Foo Bar.dmg without error. Can you provide a repro for this?

Copy link
Member

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fill out the issue template?

I also have spaces in my app name and it works fine. There was #4055 which reported that it didn't work, but we haven't heard back from the reporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants