refactor: switch to eslint v9, eslint-config-eslint v11 #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
Jan 18, 2025
Comment on lines
-14
to
-16
|
|
||
| // Remove after https://github.com/eslint/eslint/pull/17900 is included in new release | ||
| "jsdoc/no-multi-asterisks": ["error", { allowWhitespace: true }] |
Member
Author
There was a problem hiding this comment.
This is how this rule is now configured in eslint-config-eslint, so no need to override.
mdjermanovic
commented
Jan 18, 2025
Comment on lines
-34
to
-41
| "n/no-extraneous-require": [ | ||
| "error", | ||
| { | ||
| allowModules: [ | ||
| "@octokit/rest" | ||
| ] | ||
| } | ||
| ] |
Member
Author
There was a problem hiding this comment.
We're not using @octokit/rest in tests anymore, so there's no need to override the config for this rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to latest eslint v9, and latest eslint-config-eslint v11 (which is now possible since the bot runs in Node 22 where new syntax and language features that config enforces are available).