Skip to content

Conversation

@sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Nov 28, 2025

Why

We want to streamline DX of the worker part of EAS. Part of it is colocating all code in one repository.

How

Copied code over to eas-cli. Adjusted code — each commit represents a single piece of work towards adjusting code to this repository. The main changes are around removing dependency on turtle-v2 internal libraries.

One thing to figure out still is deployment process. I've added build-and-deploy-worker which is capable of deploying to staging and production. The question is how to automate it. In turtle-v2 we have system tests. Should we just copy them over to here? (Don't like that.) Should we streamline system tests and instead of having this weird turtle-v2-example repo, create project on the go? Should we deploy worker manually for now?

Test Plan

Deployed worker to staging. Ran system tests. They succeeded!! https://github.com/expo/turtle-v2/actions/runs/20042956545/job/57535011098

@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch from ac763be to 5e00ef2 Compare November 28, 2025 15:03
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Size Change: +83.1 kB (+0.15%)

Total Size: 55 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55 MB +83.1 kB (+0.15%)

compressed-size-action

@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch from e509d68 to 833de30 Compare November 28, 2025 15:40
@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch 2 times, most recently from d07514d to 6fd3287 Compare November 28, 2025 15:50
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 16.41366% with 1762 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.21%. Comparing base (4476c87) to head (9708f23).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...kages/worker/src/__integration__/stateSync.test.ts 0.00% 187 Missing ⚠️
packages/worker/src/service.ts 0.00% 150 Missing and 13 partials ⚠️
...ages/worker/src/__integration__/abortBuild.test.ts 0.00% 151 Missing ⚠️
.../src/__integration__/possiblyHangingWorker.test.ts 0.00% 96 Missing ⚠️
packages/worker/src/external/analytics.ts 19.82% 80 Missing and 5 partials ⚠️
packages/worker/src/env.ts 0.00% 70 Missing and 14 partials ⚠️
packages/worker/src/runtimeEnvironment.ts 50.96% 74 Missing and 3 partials ⚠️
packages/worker/src/displayRuntimeInfo.ts 0.00% 65 Missing and 6 partials ⚠️
packages/worker/src/upload.ts 60.51% 59 Missing and 3 partials ⚠️
packages/worker/src/utils/WebSocketServer.ts 0.00% 59 Missing and 3 partials ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   51.90%   49.21%   -2.68%     
==========================================
  Files         632      669      +37     
  Lines       25874    28005    +2131     
  Branches     5438     5764     +326     
==========================================
+ Hits        13427    13780     +353     
- Misses      11327    13035    +1708     
- Partials     1120     1190      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch from 73c547b to 94c4f9c Compare November 28, 2025 20:15
@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch from 94c4f9c to 6bf9ac6 Compare December 1, 2025 09:35
@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch 3 times, most recently from a132a7b to 9970a4a Compare December 9, 2025 10:18
@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch 2 times, most recently from c427bac to b8047fd Compare December 9, 2025 11:48
@sjchmiela sjchmiela force-pushed the stanley/move-worker-to-here branch from b8047fd to 9708f23 Compare December 9, 2025 15:43
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants