-
Notifications
You must be signed in to change notification settings - Fork 162
[worker] Add worker from turtle-v2 #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We'll source `.direnv/test` secrets in CI directly
ac763be to
5e00ef2
Compare
|
Size Change: +83.1 kB (+0.15%) Total Size: 55 MB
|
e509d68 to
833de30
Compare
# This is the 1st commit message: Use `GCS` from `@expo/build-tools` # The commit message #2 will be skipped: # fixup! Use `GCS` from `@expo/build-tools`
d07514d to
6fd3287
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
- Coverage 51.90% 49.21% -2.68%
==========================================
Files 632 669 +37
Lines 25874 28005 +2131
Branches 5438 5764 +326
==========================================
+ Hits 13427 13780 +353
- Misses 11327 13035 +1708
- Partials 1120 1190 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
73c547b to
94c4f9c
Compare
94c4f9c to
6bf9ac6
Compare
a132a7b to
9970a4a
Compare
c427bac to
b8047fd
Compare
b8047fd to
9708f23
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Why
We want to streamline DX of the worker part of EAS. Part of it is colocating all code in one repository.
How
Copied code over to
eas-cli. Adjusted code — each commit represents a single piece of work towards adjusting code to this repository. The main changes are around removing dependency onturtle-v2internal libraries.One thing to figure out still is deployment process. I've added
build-and-deploy-workerwhich is capable of deploying to staging and production. The question is how to automate it. Inturtle-v2we have system tests. Should we just copy them over to here? (Don't like that.) Should we streamline system tests and instead of having this weirdturtle-v2-examplerepo, create project on the go? Should we deploy worker manually for now?Test Plan
Deployed worker to staging. Ran system tests. They succeeded!! https://github.com/expo/turtle-v2/actions/runs/20042956545/job/57535011098