Skip to content

bug(header) inconsistent and absent focus and hover states #181

@mousemke

Description

@mousemke

page header links have some issues (some were changing the order the scss was loaded in the webpack bundle)

application name
+ missing hover state
+ missing focus state

language dropdown
+ not even focusable. this is a problem addressed by #176

login / out
+ missing focus state
+ no labels of any kind (text or aria), nor any identifying mark as to what it should do

general
+ when you actually hover things, the text color is the element but the background color is it's parent - the <li> - which also has a hover state. this doesnt seem like a good pattern to follow

screen shot 2018-06-21 at 13 55 48

i will fix these, and use the fixes in lumberjack. should i keep these fixes in lumberjack's fork, or should it be applied to this one as well? (and in the latter case, what colors etc should i use?)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions